Re: Giving your own patches your Reviewed-by

2025-03-13 Thread Markus Armbruster
CLEMENT MATHIEU--DRIF writes: > On 12/03/2025 13:54, Yi Liu wrote: [...] >> Commit eda4c9b5b3c is the similar case. Zhenzhong and Clément took >> the patch from me and I was cced when Zhenzhong sent it out. I gave >> my r-b after reviewing it. > > Some other commits of the same series were in a

Re: Giving your own patches your Reviewed-by

2025-03-12 Thread CLEMENT MATHIEU--DRIF
On 12/03/2025 13:54, Yi Liu wrote: > Caution: External email. Do not open attachments or click links, unless > this email comes from a known sender and you know the content is safe. > > > On 2025/3/12 18:03, Philippe Mathieu-Daudé wrote: >> Hi Markus, >> >> (Cc'ing Yi, Clément and Zhenzhong fo

Re: Giving your own patches your Reviewed-by

2025-03-12 Thread Markus Armbruster
bibo mao writes: > Ah, It is a pity and bad news that I contribute almost 30% of it :( > LoongArch system actually needs more people participation and I need notice > this also. It should happens in future again in LoongArch subsystem. > > Any reviewing comments is welcome and I will slow down f

Re: Giving your own patches your Reviewed-by

2025-03-12 Thread bibo mao
Ah, It is a pity and bad news that I contribute almost 30% of it :( LoongArch system actually needs more people participation and I need notice this also. It should happens in future again in LoongArch subsystem. Any reviewing comments is welcome and I will slow down for deeper considerations.

Giving your own patches your Reviewed-by

2025-03-12 Thread Markus Armbruster
I stumbled over commits that carry the author's Reviewed-by. There may be cases where the recorded author isn't the lone author, and the recorded author did some meaningful review of the patch's parts that are not theirs. Mind that we do need all authors to provide their Signed-off-by. When the

Re: Giving your own patches your Reviewed-by

2025-03-12 Thread Yi Liu
On 2025/3/12 18:03, Philippe Mathieu-Daudé wrote: Hi Markus, (Cc'ing Yi, Clément and Zhenzhong for commit eda4c9b5b3c) On 12/3/25 10:45, Markus Armbruster wrote: I stumbled over commits that carry the author's Reviewed-by. There may be cases where the recorded author isn't the lone author, an

Re: Giving your own patches your Reviewed-by

2025-03-12 Thread Philippe Mathieu-Daudé
On 12/3/25 11:45, Daniel P. Berrangé wrote: On Wed, Mar 12, 2025 at 10:45:29AM +0100, Markus Armbruster wrote: I stumbled over commits that carry the author's Reviewed-by. There may be cases where the recorded author isn't the lone author, and the recorded author did some meaningful review of t

Re: Giving your own patches your Reviewed-by

2025-03-12 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Since you are looking at this, it reminds me an orthogonal discussion > we refresh from time to time at the KVM forum conference: is it OK to > merge unreviewed patches? We should make an effort to get reviews. If we can't get any within a reasonable time, mergi

Re: Giving your own patches your Reviewed-by

2025-03-12 Thread Daniel P . Berrangé
On Wed, Mar 12, 2025 at 10:45:29AM +0100, Markus Armbruster wrote: > I stumbled over commits that carry the author's Reviewed-by. > > There may be cases where the recorded author isn't the lone author, and > the recorded author did some meaningful review of the patch's parts that > are not theirs.

Re: Giving your own patches your Reviewed-by

2025-03-12 Thread Philippe Mathieu-Daudé
On 12/3/25 10:45, Markus Armbruster wrote: I stumbled over commits that carry the author's Reviewed-by. There may be cases where the recorded author isn't the lone author, and the recorded author did some meaningful review of the patch's parts that are not theirs. Mind that we do need all autho

Re: Giving your own patches your Reviewed-by

2025-03-12 Thread Daniel P . Berrangé
On Wed, Mar 12, 2025 at 11:03:04AM +0100, Philippe Mathieu-Daudé wrote: > Hi Markus, > > (Cc'ing Yi, Clément and Zhenzhong for commit eda4c9b5b3c) > > On 12/3/25 10:45, Markus Armbruster wrote: > > I stumbled over commits that carry the author's Reviewed-by. > > > > There may be cases where the

Re: Giving your own patches your Reviewed-by

2025-03-12 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Hi Markus, > (Cc'ing Yi, Clément and Zhenzhong for commit eda4c9b5b3c) > > On 12/3/25 10:45, Markus Armbruster wrote: >> I stumbled over commits that carry the author's Reviewed-by. >> >> There may be cases where the recorded author isn't the lone author, and >>

Re: Giving your own patches your Reviewed-by

2025-03-12 Thread Philippe Mathieu-Daudé
Hi Markus, (Cc'ing Yi, Clément and Zhenzhong for commit eda4c9b5b3c) On 12/3/25 10:45, Markus Armbruster wrote: I stumbled over commits that carry the author's Reviewed-by. There may be cases where the recorded author isn't the lone author, and the recorded author did some meaningful review of