Re: Getting whole-tree patches reviewed and merged

2020-02-10 Thread Peter Maydell
On Mon, 10 Feb 2020 at 16:04, Markus Armbruster wrote: > Once that's done, the next questions are what level of review we want > for the instances of the pattern, and how to merge the thing. > > One way is to split along subsystems boundaries, and ask subsystem > maintainers to merge their part.

Re: Getting whole-tree patches reviewed and merged

2020-02-10 Thread Markus Armbruster
Paolo Bonzini writes: > On 07/02/20 22:53, Eric Blake wrote: >> On 1/21/20 11:16 PM, Markus Armbruster wrote: >>> Peter Maydell writes: >>> On Tue, 21 Jan 2020 at 15:11, Marc-André Lureau wrote: > There are plenty of refactoring to do. The problem when touching the > whole cod

Re: Getting whole-tree patches reviewed and merged

2020-02-10 Thread Paolo Bonzini
On 07/02/20 22:53, Eric Blake wrote: > On 1/21/20 11:16 PM, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On Tue, 21 Jan 2020 at 15:11, Marc-André Lureau >>> wrote: There are plenty of refactoring to do. The problem when touching the whole code-base, imho, is review time. It

Re: Getting whole-tree patches reviewed and merged

2020-02-07 Thread Eric Blake
On 1/21/20 11:16 PM, Markus Armbruster wrote: Peter Maydell writes: On Tue, 21 Jan 2020 at 15:11, Marc-André Lureau wrote: There are plenty of refactoring to do. The problem when touching the whole code-base, imho, is review time. It may take a couple of hours/days to come up with a cocci/sp

Getting whole-tree patches reviewed and merged (was: Integrating QOM into QAPI)

2020-01-21 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 21 Jan 2020 at 15:11, Marc-André Lureau > wrote: >> There are plenty of refactoring to do. The problem when touching the >> whole code-base, imho, is review time. It may take a couple of >> hours/days to come up with a cocci/spatch, and make various patches >> her