Re: FW: New Defects reported by Coverity Scan for QEMU

2021-11-05 Thread Paolo Bonzini
On 11/5/21 16:31, Peter Maydell wrote: The loop nest in question is (the index must be < 128) for (int offset = 1; offset < 128; offset <<= 1) { for (int k = 0; k < 128; k++) { if (!(k & offset)) { swap(vector1.ub[k], vector0.ub[k + offset]);

RE: FW: New Defects reported by Coverity Scan for QEMU

2021-11-05 Thread Taylor Simpson
> -Original Message- > From: Peter Maydell > Sent: Friday, November 5, 2021 10:31 AM > To: Taylor Simpson > Cc: qemu-devel@nongnu.org; Richard Henderson > ; Philippe Mathieu-Daudé > > Subject: Re: FW: New Defects reported by Coverity Scan for QEMU > &g

Re: FW: New Defects reported by Coverity Scan for QEMU

2021-11-05 Thread Peter Maydell
On Thu, 4 Nov 2021 at 22:34, Taylor Simpson wrote: > > Coverity is getting confused here. The index can never actually overflow. > Does Coverity have a pragma or something to tell it it's OK? > > The loop nest in question is (the index must be < 128) > for (int offset = 1; offset < 128; offs

FW: New Defects reported by Coverity Scan for QEMU

2021-11-04 Thread Taylor Simpson
Coverity is getting confused here. The index can never actually overflow. Does Coverity have a pragma or something to tell it it's OK? The loop nest in question is (the index must be < 128) for (int offset = 1; offset < 128; offset <<= 1) { for (int k = 0; k < 128; k++) {