Re: Command line QAPIfication and -readconfig

2020-11-12 Thread Andrea Bolognani
On Wed, 2020-11-11 at 11:35 +0100, Kevin Wolf wrote: > Am 11.11.2020 um 11:14 hat Daniel P. Berrangé geschrieben: > > Normally we would not mark something as deprecated unless its replacement > > is ready, because telling people "stop using this but the replacement > > doesn't exist yet" is not

Re: Command line QAPIfication and -readconfig

2020-11-11 Thread Paolo Bonzini
On 11/11/20 16:29, Kevin Wolf wrote: Yes, no question this is doable, it just requires some extra code for each option instead of reusing something existing. But it's not too bad as QDicts are at least slightly more natural for a QAPI based interface than QemuOpts. Yeah, see the series I posted

Re: Command line QAPIfication and -readconfig

2020-11-11 Thread Kevin Wolf
Am 11.11.2020 um 14:06 hat Paolo Bonzini geschrieben: > On 11/11/20 13:53, Kevin Wolf wrote: > > QDicts are one step closer to the final result, but would also have to > > be processed separately as they need only half of the processing that > > command line options need. Eventually, qobject_input_

Re: Command line QAPIfication and -readconfig

2020-11-11 Thread Paolo Bonzini
On 11/11/20 13:53, Kevin Wolf wrote: QDicts are one step closer to the final result, but would also have to be processed separately as they need only half of the processing that command line options need. Eventually, qobject_input_visitor_new_str() is what we want to use to parse strings directly

Re: Command line QAPIfication and -readconfig

2020-11-11 Thread Kevin Wolf
Am 11.11.2020 um 12:07 hat Paolo Bonzini geschrieben: > On 11/11/20 11:35, Kevin Wolf wrote: > > > IOW, I'd suggest we focus effort on introducing the new config file format > > > based on QAPI first, and once that exists, then convert these sample > > > config files in docs/config, and deprecate -

Re: Command line QAPIfication and -readconfig

2020-11-11 Thread Paolo Bonzini
On 11/11/20 11:35, Kevin Wolf wrote: IOW, I'd suggest we focus effort on introducing the new config file format based on QAPI first, and once that exists, then convert these sample config files in docs/config, and deprecate -readconfig. Fine with me. That would make introducing the new config f

Re: Command line QAPIfication and -readconfig

2020-11-11 Thread Kevin Wolf
Am 11.11.2020 um 11:14 hat Daniel P. Berrangé geschrieben: > On Wed, Nov 11, 2020 at 10:24:40AM +0100, Kevin Wolf wrote: > > Hi, > > > > while QAPIfying the chardev configuration, I noticed that dropping > > QemuOpts completely in vl.c would break -readconfig. So for now I'm > > stopping at the p

Re: Command line QAPIfication and -readconfig

2020-11-11 Thread Daniel P . Berrangé
On Wed, Nov 11, 2020 at 10:24:40AM +0100, Kevin Wolf wrote: > Hi, > > while QAPIfying the chardev configuration, I noticed that dropping > QemuOpts completely in vl.c would break -readconfig. So for now I'm > stopping at the point where internal interfaces are fully QAPIfied and > the QemuOpts int

Command line QAPIfication and -readconfig

2020-11-11 Thread Kevin Wolf
Hi, while QAPIfying the chardev configuration, I noticed that dropping QemuOpts completely in vl.c would break -readconfig. So for now I'm stopping at the point where internal interfaces are fully QAPIfied and the QemuOpts interfaces are only a thin wrapper around them. But do we already have a p