Re: 5.1.0-rc1 regression: reset fails with kvm and -cpu host

2020-07-23 Thread Vitaly Kuznetsov
Paolo Bonzini writes: > Yes, that seems correct. > Thank you! It seems we also need to not reset HF2_GIF_MASK in kvm_get_nested_state() when !svm and KVM_STATE_NESTED_GIF_SET is missing (as nVMX doesn't set it). I'll be sending the patch shortly. -- Vitaly

Re: 5.1.0-rc1 regression: reset fails with kvm and -cpu host

2020-07-23 Thread Paolo Bonzini
Yes, that seems correct. Paolo Il gio 23 lug 2020, 15:26 Vitaly Kuznetsov ha scritto: > This depends on whether the guest has performed VMXON or not I believe. > > Anyways, I *think* the fix will be: > > diff --git a/target/i386/kvm.c b/target/i386/kvm.c > index 2b6b744..75c2e68 100644 > --- a

Re: 5.1.0-rc1 regression: reset fails with kvm and -cpu host

2020-07-23 Thread Vitaly Kuznetsov
Jan Kiszka writes: > On 23.07.20 14:52, Dr. David Alan Gilbert wrote: >> * Vitaly Kuznetsov (vkuzn...@redhat.com) wrote: >>> Philippe Mathieu-Daudé writes: >>> +Vitaly On 7/23/20 10:40 AM, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: >> O

Re: 5.1.0-rc1 regression: reset fails with kvm and -cpu host

2020-07-23 Thread Jan Kiszka
On 23.07.20 14:52, Dr. David Alan Gilbert wrote: * Vitaly Kuznetsov (vkuzn...@redhat.com) wrote: Philippe Mathieu-Daudé writes: +Vitaly On 7/23/20 10:40 AM, Dr. David Alan Gilbert wrote: * Eduardo Habkost (ehabk...@redhat.com) wrote: On Wed, Jul 22, 2020 at 04:47:32PM -0400, Eduardo Habko

Re: 5.1.0-rc1 regression: reset fails with kvm and -cpu host

2020-07-23 Thread Dr. David Alan Gilbert
* Vitaly Kuznetsov (vkuzn...@redhat.com) wrote: > Philippe Mathieu-Daudé writes: > > > +Vitaly > > > > On 7/23/20 10:40 AM, Dr. David Alan Gilbert wrote: > >> * Eduardo Habkost (ehabk...@redhat.com) wrote: > >>> On Wed, Jul 22, 2020 at 04:47:32PM -0400, Eduardo Habkost wrote: > On Wed, Jul

Re: 5.1.0-rc1 regression: reset fails with kvm and -cpu host

2020-07-23 Thread Vitaly Kuznetsov
Philippe Mathieu-Daudé writes: > +Vitaly > > On 7/23/20 10:40 AM, Dr. David Alan Gilbert wrote: >> * Eduardo Habkost (ehabk...@redhat.com) wrote: >>> On Wed, Jul 22, 2020 at 04:47:32PM -0400, Eduardo Habkost wrote: On Wed, Jul 22, 2020 at 08:05:01PM +0200, Jan Kiszka wrote: > On 22.07.20

Re: 5.1.0-rc1 regression: reset fails with kvm and -cpu host

2020-07-23 Thread Philippe Mathieu-Daudé
+Vitaly On 7/23/20 10:40 AM, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: >> On Wed, Jul 22, 2020 at 04:47:32PM -0400, Eduardo Habkost wrote: >>> On Wed, Jul 22, 2020 at 08:05:01PM +0200, Jan Kiszka wrote: On 22.07.20 19:35, Eduardo Habkost wrote: > Hi Ja

Re: 5.1.0-rc1 regression: reset fails with kvm and -cpu host

2020-07-23 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > On Wed, Jul 22, 2020 at 04:47:32PM -0400, Eduardo Habkost wrote: > > On Wed, Jul 22, 2020 at 08:05:01PM +0200, Jan Kiszka wrote: > > > On 22.07.20 19:35, Eduardo Habkost wrote: > > > > Hi Jan, > > > > > > > > What was the last version where it worke

Re: 5.1.0-rc1 regression: reset fails with kvm and -cpu host

2020-07-22 Thread Eduardo Habkost
On Wed, Jul 22, 2020 at 04:47:32PM -0400, Eduardo Habkost wrote: > On Wed, Jul 22, 2020 at 08:05:01PM +0200, Jan Kiszka wrote: > > On 22.07.20 19:35, Eduardo Habkost wrote: > > > Hi Jan, > > > > > > What was the last version where it worked for you? Does using > > > "-cpu host,-vmx" help? > > >

Re: 5.1.0-rc1 regression: reset fails with kvm and -cpu host

2020-07-22 Thread Eduardo Habkost
On Wed, Jul 22, 2020 at 08:05:01PM +0200, Jan Kiszka wrote: > On 22.07.20 19:35, Eduardo Habkost wrote: > > Hi Jan, > > > > What was the last version where it worked for you? Does using > > "-cpu host,-vmx" help? > > Yeah, -vmx does indeed help. > > I didn't have the time to bisect yet. Just ch

Re: 5.1.0-rc1 regression: reset fails with kvm and -cpu host

2020-07-22 Thread Jan Kiszka
On 22.07.20 19:35, Eduardo Habkost wrote: Hi Jan, What was the last version where it worked for you? Does using "-cpu host,-vmx" help? Yeah, -vmx does indeed help. I didn't have the time to bisect yet. Just check my reflog, picked eb6490f544, and that works. HTH, Jan On Wed, Jul 22, 2

Re: 5.1.0-rc1 regression: reset fails with kvm and -cpu host

2020-07-22 Thread Eduardo Habkost
Hi Jan, What was the last version where it worked for you? Does using "-cpu host,-vmx" help? On Wed, Jul 22, 2020 at 11:15:43AM +0200, Jan Kiszka wrote: > Hi all, > > this locks up the guest: > > - qemu-system-x86_64 -enable-kvm -cpu host > - trigger hard reset > > Host kernel: 5.7.7. > Host

5.1.0-rc1 regression: reset fails with kvm and -cpu host

2020-07-22 Thread Jan Kiszka
Hi all, this locks up the guest: - qemu-system-x86_64 -enable-kvm -cpu host - trigger hard reset Host kernel: 5.7.7. Host CPU: i7-8850H Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux