Re: [kvm-unit-tests PATCH v2 8/9] arm: gic: Provide per-IRQ helper functions

2020-03-05 Thread Alexandru Elisei
Hi, I'm going to reiterate the comments I posted on this exact same patch sent by Andre [1], and add a few new ones. [1] https://www.spinics.net/lists/arm-kernel/msg767690.html On 3/5/20 9:55 AM, Andrew Jones wrote: > On Thu, Jan 30, 2020 at 12:25:09PM +0100, Eric Auger wrote: >> From: Andre Prz

Re: [kvm-unit-tests PATCH v2 8/9] arm: gic: Provide per-IRQ helper functions

2020-03-05 Thread Andrew Jones
On Thu, Jan 30, 2020 at 12:25:09PM +0100, Eric Auger wrote: > From: Andre Przywara > > A common theme when accessing per-IRQ parameters in the GIC distributor > is to set fields of a certain bit width in a range of MMIO registers. > Examples are the enabled status (one bit per IRQ), the level/edg

[kvm-unit-tests PATCH v2 8/9] arm: gic: Provide per-IRQ helper functions

2020-01-30 Thread Eric Auger
From: Andre Przywara A common theme when accessing per-IRQ parameters in the GIC distributor is to set fields of a certain bit width in a range of MMIO registers. Examples are the enabled status (one bit per IRQ), the level/edge configuration (2 bits per IRQ) or the priority (8 bits per IRQ). Ad