Re: [RFC v2 0/3] Add packed virtqueue to shadow virtqueue

2024-07-28 Thread Sahil
Hi, On Friday, July 26, 2024 11:55:14 PM GMT+5:30 Eugenio Perez Martin wrote: > On Fri, Jul 26, 2024 at 7:11 PM Sahil wrote: > > [...] > > > > Q2. > > > > I see that parts of the "vhost-vdpa" implementation is based on > > > > the assumption that SVQ uses the split vq format. For example, > > > >

Re: [RFC v2 0/3] Add packed virtqueue to shadow virtqueue

2024-07-26 Thread Eugenio Perez Martin
On Fri, Jul 26, 2024 at 7:11 PM Sahil wrote: > > Hi, > > On Friday, July 26, 2024 7:10:24 PM GMT+5:30 Eugenio Perez Martin wrote: > > On Fri, Jul 26, 2024 at 11:58 AM Sahil Siddiq wrote: > > > [...] > > > Q1. > > > In virtio_ring.h [2], new aliases with memory alignment enforcement > > > such as

Re: [RFC v2 0/3] Add packed virtqueue to shadow virtqueue

2024-07-26 Thread Sahil
Hi, On Friday, July 26, 2024 7:10:24 PM GMT+5:30 Eugenio Perez Martin wrote: > On Fri, Jul 26, 2024 at 11:58 AM Sahil Siddiq wrote: > > [...] > > Q1. > > In virtio_ring.h [2], new aliases with memory alignment enforcement > > such as "vring_desc_t" have been created. I am not sure if this > > is

Re: [RFC v2 0/3] Add packed virtqueue to shadow virtqueue

2024-07-26 Thread Eugenio Perez Martin
On Fri, Jul 26, 2024 at 11:58 AM Sahil Siddiq wrote: > > Hi, > > I have made some progress in this project and thought I would > send these changes first before continuing. I split patch v1 [1] > into two commits (#1 and #2) to make it easy to review. There are > very few changes in the first comm

[RFC v2 0/3] Add packed virtqueue to shadow virtqueue

2024-07-26 Thread Sahil Siddiq
Hi, I have made some progress in this project and thought I would send these changes first before continuing. I split patch v1 [1] into two commits (#1 and #2) to make it easy to review. There are very few changes in the first commit. The second commit has not changes. There are a few things that