Re: [RFC V1 02/14] accel: accel preinit function

2024-10-23 Thread Paolo Bonzini
On 10/17/24 17:14, Steve Sistare wrote: Extract the first part of the AccelState init_machine function into a new function preinit, which can be called without knowing any machine properties. For now call preinit and init_machine at the same place, so no functional change. For KVM I would also

Re: [RFC V1 02/14] accel: accel preinit function

2024-10-23 Thread Steven Sistare
On 10/23/2024 11:53 AM, Paolo Bonzini wrote: On 10/17/24 17:14, Steve Sistare wrote: Extract the first part of the AccelState init_machine function into a new function preinit, which can be called without knowing any machine properties.  For now call preinit and init_machine at the same place, s

Re: [RFC V1 02/14] accel: accel preinit function

2024-10-23 Thread Steven Sistare
On 10/21/2024 10:54 AM, Peter Xu wrote: On Thu, Oct 17, 2024 at 08:14:03AM -0700, Steve Sistare wrote: Extract the first part of the AccelState init_machine function into a new function preinit, which can be called without knowing any machine properties. For now call preinit and init_machine at

Re: [RFC V1 02/14] accel: accel preinit function

2024-10-21 Thread Peter Xu
On Thu, Oct 17, 2024 at 08:14:03AM -0700, Steve Sistare wrote: > Extract the first part of the AccelState init_machine function into > a new function preinit, which can be called without knowing any > machine properties. For now call preinit and init_machine at the > same place, so no functional c

Re: [RFC V1 02/14] accel: accel preinit function

2024-10-17 Thread Steven Sistare
cc Xen, whpx, and nvmm accelerator maintainers for this accelerator-specific patch. The cover letter for this series is here: https://lore.kernel.org/qemu-devel/1729178055-207271-1-git-send-email-steven.sist...@oracle.com - Steve On 10/17/2024 11:14 AM, Steve Sistare wrote: Extract the firs

[RFC V1 02/14] accel: accel preinit function

2024-10-17 Thread Steve Sistare
Extract the first part of the AccelState init_machine function into a new function preinit, which can be called without knowing any machine properties. For now call preinit and init_machine at the same place, so no functional change. Signed-off-by: Steve Sistare --- accel/accel-system.c