Re: [RFC QEMU PATCH] ui: Make the DisplayType enum entries conditional

2021-06-09 Thread Thomas Huth
On 09/06/2021 14.50, Gerd Hoffmann wrote: Hi, The #if CONFIG_SDL approach will not work because qemu will continue to report sdl as supported even when the sdl module is not installed any more. I guess we'd need a separate QMP command to fix that, which tries to load the modules first when

Re: [RFC QEMU PATCH] ui: Make the DisplayType enum entries conditional

2021-06-09 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> > The #if CONFIG_SDL approach will not work because qemu will continue to >> > report sdl as supported even when the sdl module is not installed any >> > more. >> >> I guess we'd need a separate QMP command to fix that, which tries to load >> the modules first

Re: [RFC QEMU PATCH] ui: Make the DisplayType enum entries conditional

2021-06-09 Thread Thomas Huth
On 09/06/2021 15.16, Markus Armbruster wrote: Thomas Huth writes: Libvirt's "domcapabilities" command has a way to state whether certain graphic frontends are available in QEMU or not. Originally, libvirt looked at the "--help" output of the QEMU binary to determine whether SDL was available o

Re: [RFC QEMU PATCH] ui: Make the DisplayType enum entries conditional

2021-06-09 Thread Markus Armbruster
Thomas Huth writes: > Libvirt's "domcapabilities" command has a way to state whether > certain graphic frontends are available in QEMU or not. Originally, > libvirt looked at the "--help" output of the QEMU binary to determine > whether SDL was available or not (by looking for the "-sdl" paramete

Re: [RFC QEMU PATCH] ui: Make the DisplayType enum entries conditional

2021-06-09 Thread Markus Armbruster
Gerd Hoffmann writes: > On Wed, Jun 09, 2021 at 12:02:40PM +0200, Thomas Huth wrote: >> Libvirt's "domcapabilities" command has a way to state whether >> certain graphic frontends are available in QEMU or not. Originally, >> libvirt looked at the "--help" output of the QEMU binary to determine >>

Re: [RFC QEMU PATCH] ui: Make the DisplayType enum entries conditional

2021-06-09 Thread Gerd Hoffmann
Hi, > > The #if CONFIG_SDL approach will not work because qemu will continue to > > report sdl as supported even when the sdl module is not installed any > > more. > > I guess we'd need a separate QMP command to fix that, which tries to load > the modules first when being called? Something simi

Re: [RFC QEMU PATCH] ui: Make the DisplayType enum entries conditional

2021-06-09 Thread Thomas Huth
On 09/06/2021 13.49, Gerd Hoffmann wrote: On Wed, Jun 09, 2021 at 12:29:58PM +0100, Daniel P. Berrangé wrote: On Wed, Jun 09, 2021 at 01:24:05PM +0200, Gerd Hoffmann wrote: On Wed, Jun 09, 2021 at 12:02:40PM +0200, Thomas Huth wrote: Libvirt's "domcapabilities" command has a way to state wheth

Re: [RFC QEMU PATCH] ui: Make the DisplayType enum entries conditional

2021-06-09 Thread Daniel P . Berrangé
On Wed, Jun 09, 2021 at 01:49:21PM +0200, Gerd Hoffmann wrote: > On Wed, Jun 09, 2021 at 12:29:58PM +0100, Daniel P. Berrangé wrote: > > On Wed, Jun 09, 2021 at 01:24:05PM +0200, Gerd Hoffmann wrote: > > > On Wed, Jun 09, 2021 at 12:02:40PM +0200, Thomas Huth wrote: > > > > Libvirt's "domcapabiliti

Re: [RFC QEMU PATCH] ui: Make the DisplayType enum entries conditional

2021-06-09 Thread Gerd Hoffmann
On Wed, Jun 09, 2021 at 12:29:58PM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 09, 2021 at 01:24:05PM +0200, Gerd Hoffmann wrote: > > On Wed, Jun 09, 2021 at 12:02:40PM +0200, Thomas Huth wrote: > > > Libvirt's "domcapabilities" command has a way to state whether > > > certain graphic frontends

Re: [RFC QEMU PATCH] ui: Make the DisplayType enum entries conditional

2021-06-09 Thread Daniel P . Berrangé
On Wed, Jun 09, 2021 at 01:24:05PM +0200, Gerd Hoffmann wrote: > On Wed, Jun 09, 2021 at 12:02:40PM +0200, Thomas Huth wrote: > > Libvirt's "domcapabilities" command has a way to state whether > > certain graphic frontends are available in QEMU or not. Originally, > > libvirt looked at the "--help"

Re: [RFC QEMU PATCH] ui: Make the DisplayType enum entries conditional

2021-06-09 Thread Gerd Hoffmann
On Wed, Jun 09, 2021 at 12:02:40PM +0200, Thomas Huth wrote: > Libvirt's "domcapabilities" command has a way to state whether > certain graphic frontends are available in QEMU or not. Originally, > libvirt looked at the "--help" output of the QEMU binary to determine > whether SDL was available or

[RFC QEMU PATCH] ui: Make the DisplayType enum entries conditional

2021-06-09 Thread Thomas Huth
Libvirt's "domcapabilities" command has a way to state whether certain graphic frontends are available in QEMU or not. Originally, libvirt looked at the "--help" output of the QEMU binary to determine whether SDL was available or not (by looking for the "-sdl" parameter in the help text), but since