Re: [RFC PATCH v2 2/3] plugins: cache: Enabled parameterization and added trace printing

2021-06-03 Thread Stefan Hajnoczi
On Tue, Jun 01, 2021 at 12:18:58PM +0100, Alex Bennée wrote: > > +if (tracefile) { > > +g_mutex_lock(&fmtx); > > +g_autoptr(GString) rep = g_string_new(""); > > +bool is_store = qemu_plugin_mem_is_store(info); > > +g_string_append_printf(rep, "%c: 0x%" PRIx64, >

Re: [RFC PATCH v2 2/3] plugins: cache: Enabled parameterization and added trace printing

2021-06-01 Thread Mahmoud Mandour
On Tue, Jun 1, 2021 at 1:29 PM Alex Bennée wrote: > > (Stefan CC'ed for tracing discussion) > > Mahmoud Mandour writes: > > > Made both icache and dcache configurable through plugin arguments > > and added memory trace printing in a separate file. > > Please keep the commits discreet and single

Re: [RFC PATCH v2 2/3] plugins: cache: Enabled parameterization and added trace printing

2021-06-01 Thread Mahmoud Mandour
CC'ing Emilio On Sun, May 30, 2021 at 8:37 AM Mahmoud Mandour wrote: > Made both icache and dcache configurable through plugin arguments > and added memory trace printing in a separate file. > > Signed-off-by: Mahmoud Mandour > --- > contrib/plugins/cache.c | 68 +++

Re: [RFC PATCH v2 2/3] plugins: cache: Enabled parameterization and added trace printing

2021-06-01 Thread Alex Bennée
(Stefan CC'ed for tracing discussion) Mahmoud Mandour writes: > Made both icache and dcache configurable through plugin arguments > and added memory trace printing in a separate file. Please keep the commits discreet and single topic. The memory trace is an extra feature so should be in it's

[RFC PATCH v2 2/3] plugins: cache: Enabled parameterization and added trace printing

2021-05-29 Thread Mahmoud Mandour
Made both icache and dcache configurable through plugin arguments and added memory trace printing in a separate file. Signed-off-by: Mahmoud Mandour --- contrib/plugins/cache.c | 68 +++-- 1 file changed, 66 insertions(+), 2 deletions(-) diff --git a/contrib/