Re: [RFC PATCH v2 02/78] block: add fallthrough pseudo-keyword

2023-10-17 Thread Manos Pitsidianakis
On Wed, 18 Oct 2023 01:11, Eric Blake wrote: static bool cluster_needs_new_alloc(BlockDriverState *bs, uint64_t l2_entry) { switch (qcow2_get_cluster_type(bs, l2_entry)) { case QCOW2_CLUSTER_NORMAL: +fallthrough; case QCOW2_CLUSTER_ZERO_ALLOC: Why is this one needed?

Re: [RFC PATCH v2 02/78] block: add fallthrough pseudo-keyword

2023-10-17 Thread Eric Blake
On Fri, Oct 13, 2023 at 10:56:29AM +0300, Emmanouil Pitsidianakis wrote: > In preparation of raising -Wimplicit-fallthrough to 5, replace all > fall-through comments with the fallthrough attribute pseudo-keyword. > > Signed-off-by: Emmanouil Pitsidianakis > --- > block/block-copy.c| 1 + >

[RFC PATCH v2 02/78] block: add fallthrough pseudo-keyword

2023-10-13 Thread Emmanouil Pitsidianakis
In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- block/block-copy.c| 1 + block/file-posix.c| 1 + block/io.c| 1 + block/iscsi.c | 1