Re: [RFC PATCH 3/3] target/avr: Fix SBRC/SBRS instructions

2020-07-07 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > SBRC/SBRS instructions seem to be inverted. I'm having trouble following exactly how the skip logic is meant to work. Intuitively I would expect a skip if clear to be TCG_COND_EQ because that is true if bit & mask is compared to 0 but it's not clear that what h

[RFC PATCH 3/3] target/avr: Fix SBRC/SBRS instructions

2020-07-06 Thread Philippe Mathieu-Daudé
SBRC/SBRS instructions seem to be inverted. Signed-off-by: Philippe Mathieu-Daudé --- target/avr/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/avr/translate.c b/target/avr/translate.c index fe03e676df..2f77fe3ba7 100644 --- a/target/avr/translate.c ++