Re: [RFC PATCH 3/3] configure: install meson to a python virtual environment

2023-04-11 Thread John Snow
On Wed, Mar 29, 2023, 9:32 AM Daniel P. Berrangé wrote: > On Wed, Mar 29, 2023 at 03:27:53PM +0200, Paolo Bonzini wrote: > > On 3/29/23 14:53, Daniel P. Berrangé wrote: > > > I would love to see a day where configure isn't involved in the > > > build process. Obviously we can't put this new logic

Re: [RFC PATCH 3/3] configure: install meson to a python virtual environment

2023-03-29 Thread Daniel P . Berrangé
On Wed, Mar 29, 2023 at 03:27:53PM +0200, Paolo Bonzini wrote: > On 3/29/23 14:53, Daniel P. Berrangé wrote: > > I would love to see a day where configure isn't involved in the > > build process. Obviously we can't put this new logic into > > meson as its a chicken & egg problem. Could we potential

Re: [RFC PATCH 3/3] configure: install meson to a python virtual environment

2023-03-29 Thread Paolo Bonzini
On 3/29/23 14:53, Daniel P. Berrangé wrote: I would love to see a day where configure isn't involved in the build process. Obviously we can't put this new logic into meson as its a chicken & egg problem. Could we potentially have your new python/scripts/mkvenv.py script be responsible for settin

Re: [RFC PATCH 3/3] configure: install meson to a python virtual environment

2023-03-29 Thread Daniel P . Berrangé
On Tue, Mar 28, 2023 at 05:11:19PM -0400, John Snow wrote: > This patch changes how we detect and install meson. > > This patch creates a lightweight Python virtual environment using the > user's configured $python that inherits system packages. If Meson is > installed there and meets our minimum

Re: [RFC PATCH 3/3] configure: install meson to a python virtual environment

2023-03-29 Thread Paolo Bonzini
On 3/28/23 23:11, John Snow wrote: +# Is it a problem if we front-load this now and run it again later? I would just move all the "pip install" bits after configure has called out to git-submodule.sh. +# --no-build-isolation was added to pip 10.0. +# --no-use-pep517 was adde

[RFC PATCH 3/3] configure: install meson to a python virtual environment

2023-03-28 Thread John Snow
This patch changes how we detect and install meson. This patch creates a lightweight Python virtual environment using the user's configured $python that inherits system packages. If Meson is installed there and meets our minimum version requirements, we will use that Meson. In the event that Meso