Re: [RFC PATCH 14/14] migration: Fix return-path thread exit

2024-02-26 Thread Cédric Le Goater
On 2/23/24 15:05, Fabiano Rosas wrote: Peter Xu writes: On Fri, Feb 16, 2024 at 02:35:26PM -0300, Fabiano Rosas wrote: Cédric Le Goater writes: Hello Fabiano On 2/14/24 21:35, Fabiano Rosas wrote: Cédric Le Goater writes: Hello Fabiano On 2/8/24 14:29, Fabiano Rosas wrote: Cédric Le

Re: [RFC PATCH 14/14] migration: Fix return-path thread exit

2024-02-23 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Feb 16, 2024 at 02:35:26PM -0300, Fabiano Rosas wrote: >> Cédric Le Goater writes: >> >> > Hello Fabiano >> > >> > On 2/14/24 21:35, Fabiano Rosas wrote: >> >> Cédric Le Goater writes: >> >> >> >>> Hello Fabiano >> >>> >> >>> On 2/8/24 14:29, Fabiano Rosas wrote: >>

Re: [RFC PATCH 14/14] migration: Fix return-path thread exit

2024-02-22 Thread Peter Xu
On Fri, Feb 16, 2024 at 02:35:26PM -0300, Fabiano Rosas wrote: > Cédric Le Goater writes: > > > Hello Fabiano > > > > On 2/14/24 21:35, Fabiano Rosas wrote: > >> Cédric Le Goater writes: > >> > >>> Hello Fabiano > >>> > >>> On 2/8/24 14:29, Fabiano Rosas wrote: > Cédric Le Goater writes:

Re: [RFC PATCH 14/14] migration: Fix return-path thread exit

2024-02-22 Thread Peter Xu
On Mon, Feb 12, 2024 at 05:04:28PM +0100, Cédric Le Goater wrote: > and then, in background we have open questions regarding : > > * the QEMUfile implementation and its QIOChannel usage for migration > streams > * qemu_file_set_error* vs. migrate_set_error. It is confusing, at least > for me.

Re: [RFC PATCH 14/14] migration: Fix return-path thread exit

2024-02-16 Thread Fabiano Rosas
Cédric Le Goater writes: > Hello Fabiano > > On 2/14/24 21:35, Fabiano Rosas wrote: >> Cédric Le Goater writes: >> >>> Hello Fabiano >>> >>> On 2/8/24 14:29, Fabiano Rosas wrote: Cédric Le Goater writes: > In case of error, close_return_path_on_source() can perform a shutdown >>>

Re: [RFC PATCH 14/14] migration: Fix return-path thread exit

2024-02-16 Thread Cédric Le Goater
Hello Fabiano On 2/14/24 21:35, Fabiano Rosas wrote: Cédric Le Goater writes: Hello Fabiano On 2/8/24 14:29, Fabiano Rosas wrote: Cédric Le Goater writes: In case of error, close_return_path_on_source() can perform a shutdown to exit the return-path thread. However, in migrate_fd_cleanu

Re: [RFC PATCH 14/14] migration: Fix return-path thread exit

2024-02-14 Thread Fabiano Rosas
Cédric Le Goater writes: > Hello Fabiano > > On 2/8/24 14:29, Fabiano Rosas wrote: >> Cédric Le Goater writes: >> >>> In case of error, close_return_path_on_source() can perform a shutdown >>> to exit the return-path thread. However, in migrate_fd_cleanup(), >>> 'to_dst_file' is closed before

Re: [RFC PATCH 14/14] migration: Fix return-path thread exit

2024-02-12 Thread Cédric Le Goater
Hello Peter On 2/8/24 06:57, Peter Xu wrote: On Wed, Feb 07, 2024 at 02:33:47PM +0100, Cédric Le Goater wrote: In case of error, close_return_path_on_source() can perform a shutdown to exit the return-path thread. However, in migrate_fd_cleanup(), 'to_dst_file' is closed before calling close_r

Re: [RFC PATCH 14/14] migration: Fix return-path thread exit

2024-02-12 Thread Cédric Le Goater
Hello Fabiano On 2/8/24 14:29, Fabiano Rosas wrote: Cédric Le Goater writes: In case of error, close_return_path_on_source() can perform a shutdown to exit the return-path thread. However, in migrate_fd_cleanup(), 'to_dst_file' is closed before calling close_return_path_on_source() and the s

Re: [RFC PATCH 14/14] migration: Fix return-path thread exit

2024-02-08 Thread Fabiano Rosas
Cédric Le Goater writes: > In case of error, close_return_path_on_source() can perform a shutdown > to exit the return-path thread. However, in migrate_fd_cleanup(), > 'to_dst_file' is closed before calling close_return_path_on_source() > and the shutdown fails, leaving the source and destinatio

Re: [RFC PATCH 14/14] migration: Fix return-path thread exit

2024-02-07 Thread Peter Xu
On Wed, Feb 07, 2024 at 02:33:47PM +0100, Cédric Le Goater wrote: > In case of error, close_return_path_on_source() can perform a shutdown > to exit the return-path thread. However, in migrate_fd_cleanup(), > 'to_dst_file' is closed before calling close_return_path_on_source() > and the shutdown f

[RFC PATCH 14/14] migration: Fix return-path thread exit

2024-02-07 Thread Cédric Le Goater
In case of error, close_return_path_on_source() can perform a shutdown to exit the return-path thread. However, in migrate_fd_cleanup(), 'to_dst_file' is closed before calling close_return_path_on_source() and the shutdown fails, leaving the source and destination waiting for an event to occur. C