Re: [RFC PATCH 08/11] gdbstub: extend GByteArray to read register helpers

2019-11-18 Thread Richard Henderson
On 11/15/19 6:29 PM, Alex Bennée wrote: > +++ b/target/arm/helper.c > @@ -47,30 +47,27 @@ static bool get_phys_addr_lpae(CPUARMState *env, > target_ulong address, > > static void switch_mode(CPUARMState *env, int mode); > > -static int vfp_gdb_get_reg(CPUARMState *env, uint8_t *buf, int reg)

[RFC PATCH 08/11] gdbstub: extend GByteArray to read register helpers

2019-11-15 Thread Alex Bennée
Instead of passing a pointer to memory now just extend the GByteArray to all the read register helpers. They can then safely append their data through the normal way. We don't bother with this abstraction for write registers as we have already ensured the buffer being copied from is the correct siz