Re: [RFC PATCH 04/13] migration: Fix parameter validation

2025-05-26 Thread Fabiano Rosas
Peter Xu writes: > On Thu, May 22, 2025 at 02:39:48PM -0300, Fabiano Rosas wrote: >> Actually, this doesn't work... >> >> The migrate-set-* commands have optional fields, so we need some form of >> checking has_* to know which fields the user is setting. Otherwise >> MigrationSetParameters will

Re: [RFC PATCH 04/13] migration: Fix parameter validation

2025-05-26 Thread Peter Xu
On Thu, May 22, 2025 at 02:39:48PM -0300, Fabiano Rosas wrote: > Actually, this doesn't work... > > The migrate-set-* commands have optional fields, so we need some form of > checking has_* to know which fields the user is setting. Otherwise > MigrationSetParameters will have zeros all over that w

Re: [RFC PATCH 04/13] migration: Fix parameter validation

2025-05-22 Thread Fabiano Rosas
Fabiano Rosas writes: > Peter Xu writes: > >> On Fri, Apr 11, 2025 at 04:14:34PM -0300, Fabiano Rosas wrote: >>> The migration parameters validation involves producing a temporary >>> structure which merges the current parameter values with the new >>> parameters set by the user. >>> >>> The ha

Re: [RFC PATCH 04/13] migration: Fix parameter validation

2025-05-22 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Apr 11, 2025 at 04:14:34PM -0300, Fabiano Rosas wrote: >> The migration parameters validation involves producing a temporary >> structure which merges the current parameter values with the new >> parameters set by the user. >> >> The has_ boolean fields of MigrateSetPa

Re: [RFC PATCH 04/13] migration: Fix parameter validation

2025-05-15 Thread Peter Xu
On Fri, Apr 11, 2025 at 04:14:34PM -0300, Fabiano Rosas wrote: > The migration parameters validation involves producing a temporary > structure which merges the current parameter values with the new > parameters set by the user. > > The has_ boolean fields of MigrateSetParameter are taken into > c

[RFC PATCH 04/13] migration: Fix parameter validation

2025-04-11 Thread Fabiano Rosas
The migration parameters validation involves producing a temporary structure which merges the current parameter values with the new parameters set by the user. The has_ boolean fields of MigrateSetParameter are taken into consideration when writing the temporary structure, however the copy of the