Re: [RFC PATCH 00/11] hw/nvme: reimplement all multi-aio commands with custom aiocbs

2021-06-08 Thread Stefan Hajnoczi
On Fri, Jun 04, 2021 at 08:52:26AM +0200, Klaus Jensen wrote: > From: Klaus Jensen > > This series reimplements flush, dsm, copy, zone reset and format nvm to > allow cancellation. I posted an RFC back in March ("hw/block/nvme: > convert ad-hoc aio tracking to aiocb") and I've applied some feedba

Re: [RFC PATCH 00/11] hw/nvme: reimplement all multi-aio commands with custom aiocbs

2021-06-07 Thread Klaus Jensen
On Jun 7 13:24, Vladimir Sementsov-Ogievskiy wrote: 07.06.2021 13:00, Klaus Jensen wrote: On Jun  7 10:11, Vladimir Sementsov-Ogievskiy wrote: 07.06.2021 09:17, Klaus Jensen wrote: On Jun  7 08:14, Vladimir Sementsov-Ogievskiy wrote: 04.06.2021 09:52, Klaus Jensen wrote: I've kept the RFC

Re: [RFC PATCH 00/11] hw/nvme: reimplement all multi-aio commands with custom aiocbs

2021-06-07 Thread Vladimir Sementsov-Ogievskiy
07.06.2021 13:00, Klaus Jensen wrote: On Jun  7 10:11, Vladimir Sementsov-Ogievskiy wrote: 07.06.2021 09:17, Klaus Jensen wrote: On Jun  7 08:14, Vladimir Sementsov-Ogievskiy wrote: 04.06.2021 09:52, Klaus Jensen wrote: I've kept the RFC since I'm still new to using the block layer like this

Re: [RFC PATCH 00/11] hw/nvme: reimplement all multi-aio commands with custom aiocbs

2021-06-07 Thread Klaus Jensen
On Jun 7 10:11, Vladimir Sementsov-Ogievskiy wrote: 07.06.2021 09:17, Klaus Jensen wrote: On Jun  7 08:14, Vladimir Sementsov-Ogievskiy wrote: 04.06.2021 09:52, Klaus Jensen wrote: I've kept the RFC since I'm still new to using the block layer like this. I was hoping that Stefan could find s

Re: [RFC PATCH 00/11] hw/nvme: reimplement all multi-aio commands with custom aiocbs

2021-06-07 Thread Vladimir Sementsov-Ogievskiy
07.06.2021 09:17, Klaus Jensen wrote: Hi Vladimir, Thanks for taking the time to look through this! I'll try to comment on all your observations below. On Jun  7 08:14, Vladimir Sementsov-Ogievskiy wrote: 04.06.2021 09:52, Klaus Jensen wrote: From: Klaus Jensen This series reimplements flu

Re: [RFC PATCH 00/11] hw/nvme: reimplement all multi-aio commands with custom aiocbs

2021-06-06 Thread Klaus Jensen
Hi Vladimir, Thanks for taking the time to look through this! I'll try to comment on all your observations below. On Jun 7 08:14, Vladimir Sementsov-Ogievskiy wrote: 04.06.2021 09:52, Klaus Jensen wrote: From: Klaus Jensen This series reimplements flush, dsm, copy, zone reset and format nv

Re: [RFC PATCH 00/11] hw/nvme: reimplement all multi-aio commands with custom aiocbs

2021-06-06 Thread Vladimir Sementsov-Ogievskiy
04.06.2021 09:52, Klaus Jensen wrote: From: Klaus Jensen This series reimplements flush, dsm, copy, zone reset and format nvm to allow cancellation. I posted an RFC back in March ("hw/block/nvme: convert ad-hoc aio tracking to aiocb") and I've applied some feedback from Stefan and reimplemented

[RFC PATCH 00/11] hw/nvme: reimplement all multi-aio commands with custom aiocbs

2021-06-03 Thread Klaus Jensen
From: Klaus Jensen This series reimplements flush, dsm, copy, zone reset and format nvm to allow cancellation. I posted an RFC back in March ("hw/block/nvme: convert ad-hoc aio tracking to aiocb") and I've applied some feedback from Stefan and reimplemented the remaining commands. The basic idea