Re: [RFC PATCH-for-6.2 v3] qdev-monitor: Only allow full --global .= option

2021-11-23 Thread Paolo Bonzini
On 11/22/21 15:32, Markus Armbruster wrote: qemu-system-x86_64: warning: global cfi.pflash01.secure has invalid class name what's going on here ? Off-the-cuff guess: cfi.pflash01.secure=on gets parsed as driver=cfi property=pflash01.secure value=on Once again our "anything

Re: [RFC PATCH-for-6.2 v3] qdev-monitor: Only allow full --global .= option

2021-11-22 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Sat, Nov 20, 2021 at 07:53:20AM +0100, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >> > When not all fields of the --global option are provided, >> > QEMU might crash: >> > >> > $ qemu-system-x86_64 -global driver=isa-fdc >> > qemu-system-x8

Re: [RFC PATCH-for-6.2 v3] qdev-monitor: Only allow full --global .= option

2021-11-22 Thread Daniel P . Berrangé
On Sat, Nov 20, 2021 at 07:53:20AM +0100, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > > > When not all fields of the --global option are provided, > > QEMU might crash: > > > > $ qemu-system-x86_64 -global driver=isa-fdc > > qemu-system-x86_64: ../../devel/qemu/qapi/string-inp

Re: [RFC PATCH-for-6.2 v3] qdev-monitor: Only allow full --global .= option

2021-11-19 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > When not all fields of the --global option are provided, > QEMU might crash: > > $ qemu-system-x86_64 -global driver=isa-fdc > qemu-system-x86_64: ../../devel/qemu/qapi/string-input-visitor.c:394: > string_input_visitor_new: Assertion `str' failed. > Abort

Re: [RFC PATCH-for-6.2 v3] qdev-monitor: Only allow full --global .= option

2021-11-19 Thread Philippe Mathieu-Daudé
On 11/19/21 19:46, BALATON Zoltan wrote: > On Fri, 19 Nov 2021, Philippe Mathieu-Daudé wrote: >> When not all fields of the --global option are provided, >> QEMU might crash: >> >>  $ qemu-system-x86_64 -global driver=isa-fdc >>  qemu-system-x86_64: ../../devel/qemu/qapi/string-input-visitor.c:394:

Re: [RFC PATCH-for-6.2 v3] qdev-monitor: Only allow full --global .= option

2021-11-19 Thread BALATON Zoltan
On Fri, 19 Nov 2021, Philippe Mathieu-Daudé wrote: When not all fields of the --global option are provided, QEMU might crash: $ qemu-system-x86_64 -global driver=isa-fdc qemu-system-x86_64: ../../devel/qemu/qapi/string-input-visitor.c:394: string_input_visitor_new: Assertion `str' failed. Ab

[RFC PATCH-for-6.2 v3] qdev-monitor: Only allow full --global .= option

2021-11-19 Thread Philippe Mathieu-Daudé
When not all fields of the --global option are provided, QEMU might crash: $ qemu-system-x86_64 -global driver=isa-fdc qemu-system-x86_64: ../../devel/qemu/qapi/string-input-visitor.c:394: string_input_visitor_new: Assertion `str' failed. Aborted (core dumped) Fix by only allowing --globa