Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue

2020-11-17 Thread Thomas Huth
On 17/11/2020 15.34, Matthew Rosato wrote: > On 11/17/20 9:13 AM, Cornelia Huck wrote: >> On Tue, 17 Nov 2020 09:02:37 -0500 >> Matthew Rosato wrote: >> >>> On 11/17/20 8:31 AM, Cornelia Huck wrote: On Tue, 17 Nov 2020 14:23:57 +0100 Pierre Morel wrote:    > On 11/17/20 2:00 PM

Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue

2020-11-17 Thread Cornelia Huck
On Tue, 17 Nov 2020 11:01:31 -0500 Matthew Rosato wrote: > On 11/17/20 10:17 AM, Cornelia Huck wrote: > > On Tue, 17 Nov 2020 09:34:41 -0500 > > Matthew Rosato wrote: > > > >> On 11/17/20 9:13 AM, Cornelia Huck wrote: > >>> On Tue, 17 Nov 2020 09:02:37 -0500 > >>> Matthew Rosato wrote: > >

Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue

2020-11-17 Thread Matthew Rosato
On 11/17/20 10:17 AM, Cornelia Huck wrote: On Tue, 17 Nov 2020 09:34:41 -0500 Matthew Rosato wrote: On 11/17/20 9:13 AM, Cornelia Huck wrote: On Tue, 17 Nov 2020 09:02:37 -0500 Matthew Rosato wrote: On 11/17/20 8:31 AM, Cornelia Huck wrote: On Tue, 17 Nov 2020 14:23:57 +0100 Pierre Mor

Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue

2020-11-17 Thread Cornelia Huck
On Tue, 17 Nov 2020 09:34:41 -0500 Matthew Rosato wrote: > On 11/17/20 9:13 AM, Cornelia Huck wrote: > > On Tue, 17 Nov 2020 09:02:37 -0500 > > Matthew Rosato wrote: > > > >> On 11/17/20 8:31 AM, Cornelia Huck wrote: > >>> On Tue, 17 Nov 2020 14:23:57 +0100 > >>> Pierre Morel wrote: > >>>

Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue

2020-11-17 Thread Matthew Rosato
On 11/17/20 9:13 AM, Cornelia Huck wrote: On Tue, 17 Nov 2020 09:02:37 -0500 Matthew Rosato wrote: On 11/17/20 8:31 AM, Cornelia Huck wrote: On Tue, 17 Nov 2020 14:23:57 +0100 Pierre Morel wrote: On 11/17/20 2:00 PM, Peter Maydell wrote: On Tue, 17 Nov 2020 at 12:03, Philippe Mathieu-D

Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue

2020-11-17 Thread Cornelia Huck
On Tue, 17 Nov 2020 09:02:37 -0500 Matthew Rosato wrote: > On 11/17/20 8:31 AM, Cornelia Huck wrote: > > On Tue, 17 Nov 2020 14:23:57 +0100 > > Pierre Morel wrote: > > > >> On 11/17/20 2:00 PM, Peter Maydell wrote: > >>> On Tue, 17 Nov 2020 at 12:03, Philippe Mathieu-Daudé > >>> wrote:

Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue

2020-11-17 Thread Matthew Rosato
On 11/17/20 8:31 AM, Cornelia Huck wrote: On Tue, 17 Nov 2020 14:23:57 +0100 Pierre Morel wrote: On 11/17/20 2:00 PM, Peter Maydell wrote: On Tue, 17 Nov 2020 at 12:03, Philippe Mathieu-Daudé wrote: Fix an endianness issue reported by Cornelia: s390x tcg guest on x86, virtio-pci device

Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue

2020-11-17 Thread Peter Maydell
On Tue, 17 Nov 2020 at 13:24, Pierre Morel wrote: > > > > On 11/17/20 2:00 PM, Peter Maydell wrote: > > On Tue, 17 Nov 2020 at 12:03, Philippe Mathieu-Daudé > > wrote: > >> > >> Fix an endianness issue reported by Cornelia: > >> > >>> s390x tcg guest on x86, virtio-pci devices are not detected.

Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue

2020-11-17 Thread Cornelia Huck
On Tue, 17 Nov 2020 14:23:57 +0100 Pierre Morel wrote: > On 11/17/20 2:00 PM, Peter Maydell wrote: > > On Tue, 17 Nov 2020 at 12:03, Philippe Mathieu-Daudé > > wrote: > >> > >> Fix an endianness issue reported by Cornelia: > >> > >>> s390x tcg guest on x86, virtio-pci devices are not detect

Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue

2020-11-17 Thread Pierre Morel
On 11/17/20 2:00 PM, Peter Maydell wrote: On Tue, 17 Nov 2020 at 12:03, Philippe Mathieu-Daudé wrote: Fix an endianness issue reported by Cornelia: s390x tcg guest on x86, virtio-pci devices are not detected. The relevant feature bits are visible to the guest. Same breakage with different

Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue

2020-11-17 Thread Cornelia Huck
On Tue, 17 Nov 2020 14:12:00 +0100 Philippe Mathieu-Daudé wrote: > On 11/17/20 2:00 PM, Peter Maydell wrote: > > On Tue, 17 Nov 2020 at 12:03, Philippe Mathieu-Daudé > > wrote: > >> > >> Fix an endianness issue reported by Cornelia: > >> > >>> s390x tcg guest on x86, virtio-pci devices are

Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue

2020-11-17 Thread Philippe Mathieu-Daudé
On 11/17/20 2:00 PM, Peter Maydell wrote: > On Tue, 17 Nov 2020 at 12:03, Philippe Mathieu-Daudé > wrote: >> >> Fix an endianness issue reported by Cornelia: >> >>> s390x tcg guest on x86, virtio-pci devices are not detected. The >>> relevant feature bits are visible to the guest. Same breakage w

Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue

2020-11-17 Thread Peter Maydell
On Tue, 17 Nov 2020 at 12:03, Philippe Mathieu-Daudé wrote: > > Fix an endianness issue reported by Cornelia: > > > s390x tcg guest on x86, virtio-pci devices are not detected. The > > relevant feature bits are visible to the guest. Same breakage with > > different guest kernels. > > KVM guests an

Re: [RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue

2020-11-17 Thread Cornelia Huck
On Tue, 17 Nov 2020 13:01:15 +0100 Philippe Mathieu-Daudé wrote: > Fix an endianness issue reported by Cornelia: > > > s390x tcg guest on x86, virtio-pci devices are not detected. The > > relevant feature bits are visible to the guest. Same breakage with > > different guest kernels. > > KVM gues

[RFC PATCH-for-5.2] hw/s390x/pci: Fix endianness issue

2020-11-17 Thread Philippe Mathieu-Daudé
Fix an endianness issue reported by Cornelia: > s390x tcg guest on x86, virtio-pci devices are not detected. The > relevant feature bits are visible to the guest. Same breakage with > different guest kernels. > KVM guests and s390x tcg guests on s390x are fine. Fixes: 28dc86a0729 ("s390x/pci: use