Re: [RFC PATCH] virtio: re-order vm_running and use_started checks

2022-11-04 Thread Michael S. Tsirkin
On Fri, Nov 04, 2022 at 05:58:17PM +0100, Christian Borntraeger wrote: > Am 04.11.22 um 17:51 schrieb Christian Borntraeger: > > > > > > Am 04.11.22 um 17:14 schrieb Michael S. Tsirkin: > > > On Fri, Nov 04, 2022 at 04:59:35PM +0100, Christian Borntraeger wrote: > > > > > > > > > > > > Am 04.11

Re: [RFC PATCH] virtio: re-order vm_running and use_started checks

2022-11-04 Thread Michael S. Tsirkin
On Fri, Nov 04, 2022 at 04:31:08PM +, Alex Bennée wrote: > > "Michael S. Tsirkin" writes: > > > On Fri, Oct 14, 2022 at 02:21:08PM +0100, Alex Bennée wrote: > >> During migration the virtio device state can be restored before we > >> restart the VM. As no devices can be running while the VM

Re: [RFC PATCH] virtio: re-order vm_running and use_started checks

2022-11-04 Thread Christian Borntraeger
Am 04.11.22 um 17:51 schrieb Christian Borntraeger: Am 04.11.22 um 17:14 schrieb Michael S. Tsirkin: On Fri, Nov 04, 2022 at 04:59:35PM +0100, Christian Borntraeger wrote: Am 04.11.22 um 16:56 schrieb Michael S. Tsirkin: On Fri, Oct 14, 2022 at 02:21:08PM +0100, Alex Bennée wrote: During

Re: [RFC PATCH] virtio: re-order vm_running and use_started checks

2022-11-04 Thread Christian Borntraeger
Am 04.11.22 um 17:14 schrieb Michael S. Tsirkin: On Fri, Nov 04, 2022 at 04:59:35PM +0100, Christian Borntraeger wrote: Am 04.11.22 um 16:56 schrieb Michael S. Tsirkin: On Fri, Oct 14, 2022 at 02:21:08PM +0100, Alex Bennée wrote: During migration the virtio device state can be restored be

Re: [RFC PATCH] virtio: re-order vm_running and use_started checks

2022-11-04 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Fri, Oct 14, 2022 at 02:21:08PM +0100, Alex Bennée wrote: >> During migration the virtio device state can be restored before we >> restart the VM. As no devices can be running while the VM is paused it >> makes sense to bail out early in that case. >> >> This

Re: [RFC PATCH] virtio: re-order vm_running and use_started checks

2022-11-04 Thread Michael S. Tsirkin
On Fri, Nov 04, 2022 at 04:59:35PM +0100, Christian Borntraeger wrote: > > > Am 04.11.22 um 16:56 schrieb Michael S. Tsirkin: > > On Fri, Oct 14, 2022 at 02:21:08PM +0100, Alex Bennée wrote: > > > During migration the virtio device state can be restored before we > > > restart the VM. As no devic

Re: [RFC PATCH] virtio: re-order vm_running and use_started checks

2022-11-04 Thread Michael S. Tsirkin
On Fri, Nov 04, 2022 at 04:59:35PM +0100, Christian Borntraeger wrote: > > > Am 04.11.22 um 16:56 schrieb Michael S. Tsirkin: > > On Fri, Oct 14, 2022 at 02:21:08PM +0100, Alex Bennée wrote: > > > During migration the virtio device state can be restored before we > > > restart the VM. As no devic

Re: [RFC PATCH] virtio: re-order vm_running and use_started checks

2022-11-04 Thread Christian Borntraeger
Am 04.11.22 um 16:56 schrieb Michael S. Tsirkin: On Fri, Oct 14, 2022 at 02:21:08PM +0100, Alex Bennée wrote: During migration the virtio device state can be restored before we restart the VM. As no devices can be running while the VM is paused it makes sense to bail out early in that case.

Re: [RFC PATCH] virtio: re-order vm_running and use_started checks

2022-11-04 Thread Michael S. Tsirkin
On Fri, Oct 14, 2022 at 02:21:08PM +0100, Alex Bennée wrote: > During migration the virtio device state can be restored before we > restart the VM. As no devices can be running while the VM is paused it > makes sense to bail out early in that case. > > This returns the order introduced in: > > 9

Re: [RFC PATCH] virtio: re-order vm_running and use_started checks

2022-11-03 Thread Michael S. Tsirkin
On Fri, Oct 14, 2022 at 02:21:08PM +0100, Alex Bennée wrote: > During migration the virtio device state can be restored before we > restart the VM. As no devices can be running while the VM is paused it > makes sense to bail out early in that case. > > This returns the order introduced in: > > 9

Re: [RFC PATCH] virtio: re-order vm_running and use_started checks

2022-10-26 Thread Michael S. Tsirkin
On Fri, Oct 14, 2022 at 02:21:08PM +0100, Alex Bennée wrote: > During migration the virtio device state can be restored before we > restart the VM. As no devices can be running while the VM is paused it > makes sense to bail out early in that case. > > This returns the order introduced in: > > 9

Re: [RFC PATCH] virtio: re-order vm_running and use_started checks

2022-10-17 Thread Philippe Mathieu-Daudé
On 14/10/22 15:21, Alex Bennée wrote: During migration the virtio device state can be restored before we restart the VM. As no devices can be running while the VM is paused it makes sense to bail out early in that case. This returns the order introduced in: 9f6bcfd99f (hw/virtio: move vm_runn

Re: [RFC PATCH] virtio: re-order vm_running and use_started checks

2022-10-14 Thread Christian Borntraeger
Am 14.10.22 um 15:21 schrieb Alex Bennée: During migration the virtio device state can be restored before we restart the VM. As no devices can be running while the VM is paused it makes sense to bail out early in that case. This returns the order introduced in: 9f6bcfd99f (hw/virtio: move

[RFC PATCH] virtio: re-order vm_running and use_started checks

2022-10-14 Thread Alex Bennée
During migration the virtio device state can be restored before we restart the VM. As no devices can be running while the VM is paused it makes sense to bail out early in that case. This returns the order introduced in: 9f6bcfd99f (hw/virtio: move vm_running check to virtio_device_started) to w