Re: [RFC PATCH] tests/functional: Don't fail any precaching errors

2025-03-12 Thread Thomas Huth
On 12/03/2025 00.41, Nicholas Piggin wrote: ... I think *no* precaching errors including 404 should cause failure because you would still want other tests to proceed (in some cases). But the failure should be caught when the test case tries to fetch the asset, so you can still easily identify th

Re: [RFC PATCH] tests/functional: Don't fail any precaching errors

2025-03-12 Thread Nicholas Piggin
On Wed Mar 12, 2025 at 4:36 PM AEST, Thomas Huth wrote: > On 12/03/2025 00.41, Nicholas Piggin wrote: > ... >> I think *no* precaching errors including 404 should cause >> failure because you would still want other tests to proceed >> (in some cases). >> >> But the failure should be caught when th

Re: [RFC PATCH] tests/functional: Don't fail any precaching errors

2025-03-11 Thread Nicholas Piggin
On Wed Mar 12, 2025 at 12:11 AM AEST, Daniel P. Berrangé wrote: > On Tue, Mar 11, 2025 at 02:55:25PM +0100, Thomas Huth wrote: >> On 11/03/2025 14.37, Daniel P. Berrangé wrote: >> > On Tue, Mar 11, 2025 at 11:13:26PM +1000, Nicholas Piggin wrote: >> > > The NetBSD archive is currently failing part-

Re: [RFC PATCH] tests/functional: Don't fail any precaching errors

2025-03-11 Thread Nicholas Piggin
On Tue Mar 11, 2025 at 11:37 PM AEST, Daniel P. Berrangé wrote: > On Tue, Mar 11, 2025 at 11:13:26PM +1000, Nicholas Piggin wrote: >> The NetBSD archive is currently failing part-way through downloads, >> which results in no clean HTTP error but a short transfer and checksum >> error. This is treat

Re: [RFC PATCH] tests/functional: Don't fail any precaching errors

2025-03-11 Thread Daniel P . Berrangé
On Tue, Mar 11, 2025 at 11:13:26PM +1000, Nicholas Piggin wrote: > The NetBSD archive is currently failing part-way through downloads, > which results in no clean HTTP error but a short transfer and checksum > error. This is treated as fatal in the precache download, and it halts > an entire set of

Re: [RFC PATCH] tests/functional: Don't fail any precaching errors

2025-03-11 Thread Daniel P . Berrangé
On Tue, Mar 11, 2025 at 02:55:25PM +0100, Thomas Huth wrote: > On 11/03/2025 14.37, Daniel P. Berrangé wrote: > > On Tue, Mar 11, 2025 at 11:13:26PM +1000, Nicholas Piggin wrote: > > > The NetBSD archive is currently failing part-way through downloads, > > > which results in no clean HTTP error but

Re: [RFC PATCH] tests/functional: Don't fail any precaching errors

2025-03-11 Thread Thomas Huth
On 11/03/2025 14.37, Daniel P. Berrangé wrote: On Tue, Mar 11, 2025 at 11:13:26PM +1000, Nicholas Piggin wrote: The NetBSD archive is currently failing part-way through downloads, which results in no clean HTTP error but a short transfer and checksum error. This is treated as fatal in the precac

[RFC PATCH] tests/functional: Don't fail any precaching errors

2025-03-11 Thread Nicholas Piggin
The NetBSD archive is currently failing part-way through downloads, which results in no clean HTTP error but a short transfer and checksum error. This is treated as fatal in the precache download, and it halts an entire set of tests even if some others could run. I hacked up this patch to get a bu