Re: [RFC PATCH] tcg/cpu-exec: precise single-stepping after an exception

2020-07-17 Thread Richard Henderson
On 7/17/20 4:01 AM, Luc Michel wrote: > I wrote a small test case for the interrupt side that can be run on the > virt board: ... > This is with your fix. Without it, the second stepi stops on 0x284. Awesome, thanks. > Do you want me to send it? If yes, how should I give credit to you? > Should I

Re: [RFC PATCH] tcg/cpu-exec: precise single-stepping after an exception

2020-07-17 Thread Luc Michel
On 7/16/20 11:08 PM, Richard Henderson wrote: > On 7/16/20 1:12 PM, Peter Maydell wrote: >> On Thu, 16 Jul 2020 at 11:08, Luc Michel wrote: >>> >>> When single-stepping with a debugger attached to QEMU, and when an >>> exception is raised, the debugger misses the first instruction after the >>>

Re: [RFC PATCH] tcg/cpu-exec: precise single-stepping after an exception

2020-07-16 Thread Richard Henderson
On 7/16/20 1:12 PM, Peter Maydell wrote: > On Thu, 16 Jul 2020 at 11:08, Luc Michel wrote: >> >> When single-stepping with a debugger attached to QEMU, and when an >> exception is raised, the debugger misses the first instruction after the >> exception: > > This is a long-standing bug; thanks for

Re: [RFC PATCH] tcg/cpu-exec: precise single-stepping after an exception

2020-07-16 Thread Peter Maydell
On Thu, 16 Jul 2020 at 11:08, Luc Michel wrote: > > When single-stepping with a debugger attached to QEMU, and when an > exception is raised, the debugger misses the first instruction after the > exception: This is a long-standing bug; thanks for looking at it. (https://bugs.launchpad.net/qemu/+b

Re: [RFC PATCH] tcg/cpu-exec: precise single-stepping after an exception

2020-07-16 Thread Richard Henderson
On 7/16/20 3:04 AM, Luc Michel wrote: > When single-stepping with a debugger attached to QEMU, and when an > exception is raised, the debugger misses the first instruction after the > exception: > > $ qemu-system-aarch64 -M virt -display none -cpu cortex-a53 -s -S > > $ aarch64-linux-gnu-gdb > GN

[RFC PATCH] tcg/cpu-exec: precise single-stepping after an exception

2020-07-16 Thread Luc Michel
When single-stepping with a debugger attached to QEMU, and when an exception is raised, the debugger misses the first instruction after the exception: $ qemu-system-aarch64 -M virt -display none -cpu cortex-a53 -s -S $ aarch64-linux-gnu-gdb GNU gdb (GDB) 9.2 [...] (gdb) tar rem :1234 Remote debug