Re: [RFC PATCH] target/i386: allow access_ptr to force slow path on failed probe

2024-08-13 Thread Richard Henderson
On 8/13/24 23:12, Alex Bennée wrote: Richard Henderson writes: On 8/8/24 02:02, Alex Bennée wrote: When we are using TCG plugin memory callbacks probe_access_internal will return TLB_MMIO to force the slow path for memory access. This results in probe_access returning NULL but the x86 access_

Re: [RFC PATCH] target/i386: allow access_ptr to force slow path on failed probe

2024-08-13 Thread Alex Bennée
Richard Henderson writes: > On 8/8/24 02:02, Alex Bennée wrote: >> When we are using TCG plugin memory callbacks probe_access_internal >> will return TLB_MMIO to force the slow path for memory access. This >> results in probe_access returning NULL but the x86 access_ptr function >> happily accept

Re: [RFC PATCH] target/i386: allow access_ptr to force slow path on failed probe

2024-08-07 Thread Richard Henderson
On 8/8/24 02:02, Alex Bennée wrote: When we are using TCG plugin memory callbacks probe_access_internal will return TLB_MMIO to force the slow path for memory access. This results in probe_access returning NULL but the x86 access_ptr function happily accepts an empty haddr resulting in segfault h

Re: [RFC PATCH] target/i386: allow access_ptr to force slow path on failed probe

2024-08-07 Thread Alexandre IOOSS
On 8/7/24 18:02, Alex Bennée wrote: When we are using TCG plugin memory callbacks probe_access_internal will return TLB_MMIO to force the slow path for memory access. This results in probe_access returning NULL but the x86 access_ptr function happily accepts an empty haddr resulting in segfault h

[RFC PATCH] target/i386: allow access_ptr to force slow path on failed probe

2024-08-07 Thread Alex Bennée
When we are using TCG plugin memory callbacks probe_access_internal will return TLB_MMIO to force the slow path for memory access. This results in probe_access returning NULL but the x86 access_ptr function happily accepts an empty haddr resulting in segfault hilarity. Check for an empty haddr to