Re: [RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-25 Thread Stefan Hajnoczi
On Fri, Oct 25, 2019 at 10:07:56AM +0800, Zhenyu Ye wrote: > > > On 2019/10/24 22:38, Dr. David Alan Gilbert wrote: > > * Zhenyu Ye (yezhen...@huawei.com) wrote: > >> > >> > >> On 2019/10/24 21:56, Dr. David Alan Gilbert wrote: > >>> * Zhenyu Ye (yezhen...@huawei.com) wrote: > > >

Re: [RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-24 Thread Zhenyu Ye
On 2019/10/24 22:38, Dr. David Alan Gilbert wrote: > * Zhenyu Ye (yezhen...@huawei.com) wrote: >> >> >> On 2019/10/24 21:56, Dr. David Alan Gilbert wrote: >>> * Zhenyu Ye (yezhen...@huawei.com) wrote: On 2019/10/23 23:19, Stefan Hajnoczi wrote: > On Tue, Oct 22, 2019 at 04:12:

Re: [RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-24 Thread Dr. David Alan Gilbert
* Zhenyu Ye (yezhen...@huawei.com) wrote: > > > On 2019/10/24 21:56, Dr. David Alan Gilbert wrote: > > * Zhenyu Ye (yezhen...@huawei.com) wrote: > >> > >> > >> On 2019/10/23 23:19, Stefan Hajnoczi wrote: > >>> On Tue, Oct 22, 2019 at 04:12:03PM +0800, yezhenyu (A) wrote: > Since qemu2.9, QEM

Re: [RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-24 Thread Zhenyu Ye
On 2019/10/24 21:56, Dr. David Alan Gilbert wrote: > * Zhenyu Ye (yezhen...@huawei.com) wrote: >> >> >> On 2019/10/23 23:19, Stefan Hajnoczi wrote: >>> On Tue, Oct 22, 2019 at 04:12:03PM +0800, yezhenyu (A) wrote: Since qemu2.9, QEMU added three AioContext poll parameters to struct IOT

Re: [RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-24 Thread Dr. David Alan Gilbert
* Zhenyu Ye (yezhen...@huawei.com) wrote: > > > On 2019/10/23 23:19, Stefan Hajnoczi wrote: > > On Tue, Oct 22, 2019 at 04:12:03PM +0800, yezhenyu (A) wrote: > >> Since qemu2.9, QEMU added three AioContext poll parameters to struct > >> IOThread: poll_max_ns, poll_grow and poll_shrink. These prop

Re: [RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-24 Thread Zhenyu Ye
On 2019/10/23 23:19, Stefan Hajnoczi wrote: > On Tue, Oct 22, 2019 at 04:12:03PM +0800, yezhenyu (A) wrote: >> Since qemu2.9, QEMU added three AioContext poll parameters to struct >> IOThread: poll_max_ns, poll_grow and poll_shrink. These properties are >> used to control iothread polling time.

Re: [RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-23 Thread Stefan Hajnoczi
On Tue, Oct 22, 2019 at 04:12:03PM +0800, yezhenyu (A) wrote: > Since qemu2.9, QEMU added three AioContext poll parameters to struct > IOThread: poll_max_ns, poll_grow and poll_shrink. These properties are > used to control iothread polling time. > > However, there isn't properly hmp commands to a

Re: [RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-22 Thread Eric Blake
On 10/22/19 9:28 PM, Zhenyu Ye wrote: I will change the name argument to ENUM, such as, { 'enum': 'IothreadPollProperty', 'data': [ 'max-ns', 'grow', 'shrink' ] } ok, I will correct it, such as, { 'command': 'set-iothread-poll-param', 'data': {'iothread-id': 'str', '

Re: [RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-22 Thread Zhenyu Ye
On 2019/10/23 4:40, Eric Blake wrote: > On 10/22/19 3:12 AM, yezhenyu (A) wrote: >> Since qemu2.9, QEMU added three AioContext poll parameters to struct >> IOThread: poll_max_ns, poll_grow and poll_shrink. These properties are >> used to control iothread polling time. >> >> However, there isn't

Re: [RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-22 Thread Eric Blake
On 10/22/19 3:12 AM, yezhenyu (A) wrote: Since qemu2.9, QEMU added three AioContext poll parameters to struct IOThread: poll_max_ns, poll_grow and poll_shrink. These properties are used to control iothread polling time. However, there isn't properly hmp commands to adjust them when the VM is ali

Re: [RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-22 Thread Dr. David Alan Gilbert
* Zhenyu Ye (yezhen...@huawei.com) wrote: > > > On 2019/10/22 16:51, Dr. David Alan Gilbert wrote: > > * yezhenyu (A) (yezhen...@huawei.com) wrote: > >> Since qemu2.9, QEMU added three AioContext poll parameters to struct > >> IOThread: poll_max_ns, poll_grow and poll_shrink. These properties are

Re: [RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-22 Thread Zhenyu Ye
On 2019/10/22 16:51, Dr. David Alan Gilbert wrote: > * yezhenyu (A) (yezhen...@huawei.com) wrote: >> Since qemu2.9, QEMU added three AioContext poll parameters to struct >> IOThread: poll_max_ns, poll_grow and poll_shrink. These properties are >> used to control iothread polling time. >> >> Howe

Re: [RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-22 Thread Dr. David Alan Gilbert
* yezhenyu (A) (yezhen...@huawei.com) wrote: > Since qemu2.9, QEMU added three AioContext poll parameters to struct > IOThread: poll_max_ns, poll_grow and poll_shrink. These properties are > used to control iothread polling time. > > However, there isn't properly hmp commands to adjust them when t

[RFC PATCH] iothread: add set_iothread_poll_* commands

2019-10-22 Thread yezhenyu (A)
Since qemu2.9, QEMU added three AioContext poll parameters to struct IOThread: poll_max_ns, poll_grow and poll_shrink. These properties are used to control iothread polling time. However, there isn't properly hmp commands to adjust them when the VM is alive. It's useful to adjust them online when