Re: [RFC PATCH] hw/riscv/virt: Add serial alias in DTB

2025-01-16 Thread Vasilis Liaskovitis
On Thu, Jan 16, 2025 at 10:23:56AM +0100, Andrew Jones wrote: > > s/Fixes/Resolves/ (see docs/devel/submitting-a-patch.rst) > [..] > > qemu_fdt_setprop_string(ms->fdt, "/chosen", "stdout-path", name); > > +qemu_fdt_add_subnode(ms->fdt, "/aliases"); > > create_fdt_uart() is called at mac

Re: [RFC PATCH] hw/riscv/virt: Add serial alias in DTB

2025-01-16 Thread Andrew Jones
On Thu, Jan 16, 2025 at 09:46:29AM +0100, Vasilis Liaskovitis wrote: > This patch adds an "aliases" node with a "serial0" entry for the > single UART in the riscv64 virt machine. > > This was requested in Gitlab #2774. However, since the machine only > has one UART at the moment, it's not clear th

[RFC PATCH] hw/riscv/virt: Add serial alias in DTB

2025-01-16 Thread Vasilis Liaskovitis
This patch adds an "aliases" node with a "serial0" entry for the single UART in the riscv64 virt machine. This was requested in Gitlab #2774. However, since the machine only has one UART at the moment, it's not clear that this addition makes sense. Fixes: https://gitlab.com/qemu-project/qemu/-/is