Re: [RFC 4/8] Fix some direct calls from non-coroutine_fn to coroutine_fn

2022-07-03 Thread Alberto Faria
On Sat, Jul 2, 2022 at 3:13 PM Paolo Bonzini wrote: > These functions should be coroutine_fn (all coroutine entry points > should be). Thanks, I see now that you fixed this in [1]. Alberto [1] https://patchew.org/QEMU/20220509103019.215041-1-pbonz...@redhat.com/

Re: [RFC 4/8] Fix some direct calls from non-coroutine_fn to coroutine_fn

2022-07-02 Thread Paolo Bonzini
On 7/2/22 13:33, Alberto Faria wrote: @@ -1537,8 +1537,9 @@ static void blk_aio_read_entry(void *opaque) QEMUIOVector *qiov = rwco->iobuf; assert(qiov->size == acb->bytes); -rwco->ret = blk_co_do_preadv(rwco->blk, rwco->offset, acb->bytes, - qio

[RFC 4/8] Fix some direct calls from non-coroutine_fn to coroutine_fn

2022-07-02 Thread Alberto Faria
These problems were found by static-analyzer.py. Only a few of the reported cases were fixed. Signed-off-by: Alberto Faria --- block/block-backend.c | 13 - block/copy-before-write.c | 3 ++- block/dirty-bitmap.c | 6 -- block/iscsi.c | 3 ++- block/qcow2.