Re: [RFC 3/3] tests/vhost-user-fs-test: add vhost-user-fs test case

2019-11-07 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@gmail.com) wrote: > On Tue, Oct 29, 2019 at 12:36:05AM +, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > +static void after_test(void *arg G_GNUC_UNUSED) > > > +{ > > > +unlink(socket_path); > > > + > > > +remove_dir_an

Re: [RFC 3/3] tests/vhost-user-fs-test: add vhost-user-fs test case

2019-11-05 Thread Stefan Hajnoczi
On Tue, Oct 29, 2019 at 12:36:05AM +, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > +static void after_test(void *arg G_GNUC_UNUSED) > > +{ > > +unlink(socket_path); > > + > > +remove_dir_and_children(shared_dir); > > This scares me. Especially sinc

Re: [RFC 3/3] tests/vhost-user-fs-test: add vhost-user-fs test case

2019-10-28 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > Add a test case for the vhost-user-fs device. There are two > limitations: > > 1. This test only runs when invoked as root. The virtiofsd vhost-user >device backend currently requires root in order to maintain accurate >file system ownersh

[RFC 3/3] tests/vhost-user-fs-test: add vhost-user-fs test case

2019-10-25 Thread Stefan Hajnoczi
Add a test case for the vhost-user-fs device. There are two limitations: 1. This test only runs when invoked as root. The virtiofsd vhost-user device backend currently requires root in order to maintain accurate file system ownership information (uid/gid). 2. Cross-endian is not supported