Re: [RFC 0/2] virtio-rng: add a control queue

2020-07-29 Thread Michael S. Tsirkin
On Tue, Jul 28, 2020 at 03:45:26PM +0200, Laurent Vivier wrote: > On 29/01/2020 16:43, Stefan Hajnoczi wrote: > > On Fri, Jan 24, 2020 at 03:05:18PM +0100, Laurent Vivier wrote: > >> On 24/01/2020 12:02, Stefan Hajnoczi wrote: > >>> On Thu, Jan 23, 2020 at 04:16:58PM +0100, Laurent Vivier wrote: >

Re: [RFC 0/2] virtio-rng: add a control queue

2020-07-29 Thread Stefan Hajnoczi
On Tue, Jul 28, 2020 at 03:45:26PM +0200, Laurent Vivier wrote: > On 29/01/2020 16:43, Stefan Hajnoczi wrote: > > On Fri, Jan 24, 2020 at 03:05:18PM +0100, Laurent Vivier wrote: > >> On 24/01/2020 12:02, Stefan Hajnoczi wrote: > >>> On Thu, Jan 23, 2020 at 04:16:58PM +0100, Laurent Vivier wrote: >

Re: [RFC 0/2] virtio-rng: add a control queue

2020-07-28 Thread Laurent Vivier
On 29/01/2020 16:43, Stefan Hajnoczi wrote: > On Fri, Jan 24, 2020 at 03:05:18PM +0100, Laurent Vivier wrote: >> On 24/01/2020 12:02, Stefan Hajnoczi wrote: >>> On Thu, Jan 23, 2020 at 04:16:58PM +0100, Laurent Vivier wrote: The kernel needs sometime to be able to cancel an ongoing command. >>

Re: [RFC 0/2] virtio-rng: add a control queue

2020-01-29 Thread Stefan Hajnoczi
On Fri, Jan 24, 2020 at 03:05:18PM +0100, Laurent Vivier wrote: > On 24/01/2020 12:02, Stefan Hajnoczi wrote: > > On Thu, Jan 23, 2020 at 04:16:58PM +0100, Laurent Vivier wrote: > >> The kernel needs sometime to be able to cancel an ongoing command. > >> > >> For instance, if the virtio-rng device

Re: [RFC 0/2] virtio-rng: add a control queue

2020-01-24 Thread Laurent Vivier
On 24/01/2020 12:02, Stefan Hajnoczi wrote: > On Thu, Jan 23, 2020 at 04:16:58PM +0100, Laurent Vivier wrote: >> The kernel needs sometime to be able to cancel an ongoing command. >> >> For instance, if the virtio-rng device uses the egd backend >> and this backend doesn't provide data, the buffer

Re: [RFC 0/2] virtio-rng: add a control queue

2020-01-24 Thread Stefan Hajnoczi
On Thu, Jan 23, 2020 at 04:16:58PM +0100, Laurent Vivier wrote: > The kernel needs sometime to be able to cancel an ongoing command. > > For instance, if the virtio-rng device uses the egd backend > and this backend doesn't provide data, the buffer provided by the > kernel is kept as long as it is

Re: [RFC 0/2] virtio-rng: add a control queue

2020-01-24 Thread Laurent Vivier
On 24/01/2020 13:43, Amit Shah wrote: > On Thu, 2020-01-23 at 16:16 +0100, Laurent Vivier wrote: >> The kernel needs sometime to be able to cancel an ongoing command. >> >> For instance, if the virtio-rng device uses the egd backend >> and this backend doesn't provide data, the buffer provided by t

Re: [RFC 0/2] virtio-rng: add a control queue

2020-01-24 Thread Amit Shah
On Thu, 2020-01-23 at 16:16 +0100, Laurent Vivier wrote: > The kernel needs sometime to be able to cancel an ongoing command. > > For instance, if the virtio-rng device uses the egd backend > and this backend doesn't provide data, the buffer provided by the > kernel is kept as long as it is needed

[RFC 0/2] virtio-rng: add a control queue

2020-01-23 Thread Laurent Vivier
The kernel needs sometime to be able to cancel an ongoing command. For instance, if the virtio-rng device uses the egd backend and this backend doesn't provide data, the buffer provided by the kernel is kept as long as it is needed. On the kernel side, a read blocks until the buffer returns from