Re: [RFC] virt/acpi: set PSCI flag even when psci_conduit is disabled

2020-07-07 Thread Andrew Jones
On Tue, Jul 07, 2020 at 11:15:30AM +0100, Peter Maydell wrote: > On Tue, 7 Jul 2020 at 11:04, Andrew Jones wrote: > > This seems a bit messy to me. With an EL3 firmware, the DTB is provided > > by the EL3 firmware. I guess that's why when I look at the DTB generation > > in virt.c we don't properl

Re: [RFC] virt/acpi: set PSCI flag even when psci_conduit is disabled

2020-07-07 Thread Peter Maydell
On Tue, 7 Jul 2020 at 11:04, Andrew Jones wrote: > This seems a bit messy to me. With an EL3 firmware, the DTB is provided > by the EL3 firmware. I guess that's why when I look at the DTB generation > in virt.c we don't properly set "enable-method" of the CPUs to > "spin-table", even though we don

Re: [RFC] virt/acpi: set PSCI flag even when psci_conduit is disabled

2020-07-07 Thread Andrew Jones
On Fri, Jul 03, 2020 at 05:43:29PM +0800, Heyi Guo wrote: > vms->psci_conduit being disabled only means PSCI is not implemented by > qemu; it doesn't mean PSCI is not supported on this virtual machine. > Actually vms->psci_conduit is set to disabled when vms->secure and > firmware_loaded are both s

Re: [RFC] virt/acpi: set PSCI flag even when psci_conduit is disabled

2020-07-07 Thread Andrew Jones
On Fri, Jul 03, 2020 at 03:41:05PM +0100, Peter Maydell wrote: > On Fri, 3 Jul 2020 at 15:36, Heyi Guo wrote: > > > > > > 在 2020/7/3 下午6:37, Peter Maydell 写道: > > > On Fri, 3 Jul 2020 at 10:44, Heyi Guo wrote: > > >> vms->psci_conduit being disabled only means PSCI is not implemented by > > >> qe

Re: [RFC] virt/acpi: set PSCI flag even when psci_conduit is disabled

2020-07-04 Thread Michael S. Tsirkin
On Fri, Jul 03, 2020 at 11:37:02AM +0100, Peter Maydell wrote: > On Fri, 3 Jul 2020 at 10:44, Heyi Guo wrote: > > > > vms->psci_conduit being disabled only means PSCI is not implemented by > > qemu; it doesn't mean PSCI is not supported on this virtual machine. > > Actually vms->psci_conduit is se

Re: [RFC] virt/acpi: set PSCI flag even when psci_conduit is disabled

2020-07-03 Thread Peter Maydell
On Fri, 3 Jul 2020 at 15:36, Heyi Guo wrote: > > > 在 2020/7/3 下午6:37, Peter Maydell 写道: > > On Fri, 3 Jul 2020 at 10:44, Heyi Guo wrote: > >> vms->psci_conduit being disabled only means PSCI is not implemented by > >> qemu; it doesn't mean PSCI is not supported on this virtual machine. > >> Actua

Re: [RFC] virt/acpi: set PSCI flag even when psci_conduit is disabled

2020-07-03 Thread Heyi Guo
在 2020/7/3 下午6:37, Peter Maydell 写道: On Fri, 3 Jul 2020 at 10:44, Heyi Guo wrote: vms->psci_conduit being disabled only means PSCI is not implemented by qemu; it doesn't mean PSCI is not supported on this virtual machine. Actually vms->psci_conduit is set to disabled when vms->secure and firm

[RFC] virt/acpi: set PSCI flag even when psci_conduit is disabled

2020-07-03 Thread Heyi Guo
vms->psci_conduit being disabled only means PSCI is not implemented by qemu; it doesn't mean PSCI is not supported on this virtual machine. Actually vms->psci_conduit is set to disabled when vms->secure and firmware_loaded are both set, which means we will run ARM trusted firmware, which will defin

Re: [RFC] virt/acpi: set PSCI flag even when psci_conduit is disabled

2020-07-03 Thread Peter Maydell
On Fri, 3 Jul 2020 at 10:44, Heyi Guo wrote: > > vms->psci_conduit being disabled only means PSCI is not implemented by > qemu; it doesn't mean PSCI is not supported on this virtual machine. > Actually vms->psci_conduit is set to disabled when vms->secure and > firmware_loaded are both set, which