Re: [RFC] vhost: Introduce packed vq and add buffer elements

2024-06-25 Thread Sahil
Hi, On Monday, June 24, 2024 5:06:42 PM GMT+5:30 Eugenio Perez Martin wrote: > [...] > > > > /* Shadow virtqueue to relay notifications */ > > > > typedef struct VhostShadowVirtqueue { > > > > > > > > +/* Virtio queue shadowing */ > > > > +VirtQueue *vq; > > > > + > > > > +/* Virtio

Re: [RFC] vhost: Introduce packed vq and add buffer elements

2024-06-24 Thread Eugenio Perez Martin
On Sat, Jun 22, 2024 at 6:34 AM Sahil wrote: > > Hi, > > On Wednesday, June 19, 2024 3:49:29 PM GMT+5:30 Eugenio Perez Martin wrote: > > [...] > > Hi Sahil, > > > > Just some nitpicks here and there, > > > > > [1] https://wiki.qemu.org/Internships/ProjectIdeas/PackedShadowVirtqueue > > > > > > hw

Re: [RFC] vhost: Introduce packed vq and add buffer elements

2024-06-21 Thread Sahil
Hi, On Wednesday, June 19, 2024 3:49:29 PM GMT+5:30 Eugenio Perez Martin wrote: > [...] > Hi Sahil, > > Just some nitpicks here and there, > > > [1] https://wiki.qemu.org/Internships/ProjectIdeas/PackedShadowVirtqueue > > > > hw/virtio/vhost-shadow-virtqueue.c | 124 +++

Re: [RFC] vhost: Introduce packed vq and add buffer elements

2024-06-21 Thread Sahil
Hi, Thank you for your reply. On Wednesday, June 19, 2024 1:07:54 PM GMT+5:30 Eugenio Perez Martin wrote: > [...] > > "curr" is being updated here, but descs[i].id is always set to id which > > doesn't change in the loop. So all the descriptors in the chain will have > > the same id. I can't find

Re: [RFC] vhost: Introduce packed vq and add buffer elements

2024-06-19 Thread Eugenio Perez Martin
On Tue, Jun 18, 2024 at 8:19 PM Sahil Siddiq wrote: > > This is the first patch in a series to add support for packed > virtqueues in vhost_shadow_virtqueue. This patch implements the > insertion of available buffers in the descriptor area. It takes > into account descriptor chains, but does not c

Re: [RFC] vhost: Introduce packed vq and add buffer elements

2024-06-19 Thread Eugenio Perez Martin
On Tue, Jun 18, 2024 at 8:58 PM Sahil wrote: > > Hi, > > On Tuesday, June 18, 2024 11:48:34 PM GMT+5:30 Sahil Siddiq wrote: > > [...] > > > > hw/virtio/vhost-shadow-virtqueue.c | 124 - > > hw/virtio/vhost-shadow-virtqueue.h | 66 ++- > > 2 files changed,

Re: [RFC] vhost: Introduce packed vq and add buffer elements

2024-06-18 Thread Sahil
Hi, On Tuesday, June 18, 2024 11:48:34 PM GMT+5:30 Sahil Siddiq wrote: > [...] > > hw/virtio/vhost-shadow-virtqueue.c | 124 - > hw/virtio/vhost-shadow-virtqueue.h | 66 ++- > 2 files changed, 167 insertions(+), 23 deletions(-) > > diff --git a/hw/virtio/

[RFC] vhost: Introduce packed vq and add buffer elements

2024-06-18 Thread Sahil Siddiq
This is the first patch in a series to add support for packed virtqueues in vhost_shadow_virtqueue. This patch implements the insertion of available buffers in the descriptor area. It takes into account descriptor chains, but does not consider indirect descriptors. VhostShadowVirtqueue has also be