Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-29 Thread Paolo Bonzini
On 29/03/21 07:35, David Gibson wrote: regarding unplug - on device_del QEMU raises SCI interrupt, after this the process is asynchronous. When ACPI interpreter gets SCI it sends a respective _EJ0 event to devices mentioned in PCI_DOWN_BASE register. After getting the event, guest OS may

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-28 Thread David Gibson
On Tue, Mar 23, 2021 at 02:06:36PM +0100, Igor Mammedov wrote: > On Tue, 23 Mar 2021 14:33:28 +1100 > David Gibson wrote: > > > On Mon, Mar 22, 2021 at 01:06:53PM +0100, Paolo Bonzini wrote: > > > On 22/03/21 07:39, David Gibson wrote: > > > > > QEMU doesn't really keep track of "in flight" unp

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-23 Thread Igor Mammedov
On Tue, 23 Mar 2021 14:33:28 +1100 David Gibson wrote: > On Mon, Mar 22, 2021 at 01:06:53PM +0100, Paolo Bonzini wrote: > > On 22/03/21 07:39, David Gibson wrote: > > > > QEMU doesn't really keep track of "in flight" unplug requests, and as > > > > long as that's the case, its timeout even will

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-22 Thread David Gibson
On Mon, Mar 22, 2021 at 01:06:53PM +0100, Paolo Bonzini wrote: > On 22/03/21 07:39, David Gibson wrote: > > > QEMU doesn't really keep track of "in flight" unplug requests, and as > > > long as that's the case, its timeout even will have the same issue. > > Not generically, maybe. In the PAPR code

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-22 Thread Paolo Bonzini
On 22/03/21 07:39, David Gibson wrote: QEMU doesn't really keep track of "in flight" unplug requests, and as long as that's the case, its timeout even will have the same issue. Not generically, maybe. In the PAPR code we effectively do, by means of the 'unplug_requested' boolean in the DRC stru

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-22 Thread David Gibson
On Fri, Mar 12, 2021 at 08:38:47AM -0500, Laine Stump wrote: > On 3/11/21 8:19 PM, David Gibson wrote: > > On Thu, Mar 11, 2021 at 05:50:42PM -0300, Daniel Henrique Barboza wrote: > > > > > > > > > On 3/9/21 3:22 AM, Markus Armbruster wrote: > > > > Cc: Paolo and Julia in addition to Igor, becaus

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-22 Thread David Gibson
On Fri, Mar 12, 2021 at 09:12:53AM +0100, Markus Armbruster wrote: > David Gibson writes: > > > On Thu, Mar 11, 2021 at 05:50:42PM -0300, Daniel Henrique Barboza wrote: > >> > >> > >> On 3/9/21 3:22 AM, Markus Armbruster wrote: > >> > Cc: Paolo and Julia in addition to Igor, because the thread

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-19 Thread Markus Armbruster
Markus Armbruster writes: > David Gibson writes: > >> On Thu, Mar 11, 2021 at 05:50:42PM -0300, Daniel Henrique Barboza wrote: >>> >>> >>> On 3/9/21 3:22 AM, Markus Armbruster wrote: >>> > Cc: Paolo and Julia in addition to Igor, because the thread is wandering >>> > towards DeviceState member

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-12 Thread Laine Stump
On 3/11/21 8:19 PM, David Gibson wrote: On Thu, Mar 11, 2021 at 05:50:42PM -0300, Daniel Henrique Barboza wrote: On 3/9/21 3:22 AM, Markus Armbruster wrote: Cc: Paolo and Julia in addition to Igor, because the thread is wandering towards DeviceState member pending_deleted_event. Cc: Laine fo

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-12 Thread Markus Armbruster
David Gibson writes: > On Thu, Mar 11, 2021 at 05:50:42PM -0300, Daniel Henrique Barboza wrote: >> >> >> On 3/9/21 3:22 AM, Markus Armbruster wrote: >> > Cc: Paolo and Julia in addition to Igor, because the thread is wandering >> > towards DeviceState member pending_deleted_event. >> > >> > Cc

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-11 Thread David Gibson
On Thu, Mar 11, 2021 at 05:50:42PM -0300, Daniel Henrique Barboza wrote: > > > On 3/9/21 3:22 AM, Markus Armbruster wrote: > > Cc: Paolo and Julia in addition to Igor, because the thread is wandering > > towards DeviceState member pending_deleted_event. > > > > Cc: Laine for libvirt expertise.

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-11 Thread Daniel Henrique Barboza
On 3/9/21 3:22 AM, Markus Armbruster wrote: Cc: Paolo and Julia in addition to Igor, because the thread is wandering towards DeviceState member pending_deleted_event. Cc: Laine for libvirt expertise. Laine, if you're not the right person, please loop in the right person. David Gibson write

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-08 Thread Markus Armbruster
Cc: Paolo and Julia in addition to Igor, because the thread is wandering towards DeviceState member pending_deleted_event. Cc: Laine for libvirt expertise. Laine, if you're not the right person, please loop in the right person. David Gibson writes: > On Mon, Mar 08, 2021 at 03:01:53PM -0300, D

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-08 Thread David Gibson
On Mon, Mar 08, 2021 at 03:01:53PM -0300, Daniel Henrique Barboza wrote: > > > On 3/8/21 2:04 PM, Markus Armbruster wrote: > > Daniel Henrique Barboza writes: > > > > > On 3/6/21 3:57 AM, Markus Armbruster wrote: > > > > Cc: ACPI maintainers for additional expertise. > > > > > > > > Daniel Hen

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-08 Thread Daniel Henrique Barboza
On 3/8/21 2:04 PM, Markus Armbruster wrote: Daniel Henrique Barboza writes: On 3/6/21 3:57 AM, Markus Armbruster wrote: Cc: ACPI maintainers for additional expertise. Daniel Henrique Barboza writes: Hi, Recent changes in pseries code (not yet pushed, available at David's ppc-for-6.0)

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-08 Thread Markus Armbruster
Daniel Henrique Barboza writes: > On 3/6/21 3:57 AM, Markus Armbruster wrote: >> Cc: ACPI maintainers for additional expertise. >> >> Daniel Henrique Barboza writes: >> >>> Hi, >>> >>> Recent changes in pseries code (not yet pushed, available at David's >>> ppc-for-6.0) are using the QAPI even

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-08 Thread Daniel Henrique Barboza
On 3/6/21 3:57 AM, Markus Armbruster wrote: Cc: ACPI maintainers for additional expertise. Daniel Henrique Barboza writes: Hi, Recent changes in pseries code (not yet pushed, available at David's ppc-for-6.0) are using the QAPI event MEM_UNPLUG_ERROR to report memory hotunplug errors in t

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-05 Thread Markus Armbruster
Cc: ACPI maintainers for additional expertise. Daniel Henrique Barboza writes: > Hi, > > Recent changes in pseries code (not yet pushed, available at David's > ppc-for-6.0) are using the QAPI event MEM_UNPLUG_ERROR to report memory > hotunplug errors in the pseries machine. > > The pseries machi

[RFC] adding a generic QAPI event for failed device hotunplug

2021-03-05 Thread Daniel Henrique Barboza
Hi, Recent changes in pseries code (not yet pushed, available at David's ppc-for-6.0) are using the QAPI event MEM_UNPLUG_ERROR to report memory hotunplug errors in the pseries machine. The pseries machine is also using a timeout to cancel CPU hotunplugs that takes too long to finish (in which w