--
主 题：Re: [RESEND PATCH] virtio-pci: fix vector_irqfd leak in virtio_pci_set_guest_notifiers 日 期：2022-12-20 22:42 发件人：Michael S. Tsirkin 收件人：雷翔;
On Wed, Nov 30, 2022 at 01:56:11PM +0800, leixiang wrote:> proxy->vector_irqfd did not free when set guest notifier failed.Can you pls add a F
On Wed, Nov 30, 2022 at 01:56:11PM +0800, leixiang wrote:
> proxy->vector_irqfd did not free when set guest notifier failed.
Can you pls add a Fixes tag so people know where to backport this?
> Signed-off-by: Lei Xiang
> Tested-by: Zeng Chi
> Suggested-by: Xie Ming
Looking at the code I see t
set_vector_notifiers: Assertion `dev->
> msix_vector_use_notifier && dev->msix_vector_release_notifier' failed.
> 2022-07-29 07:52:53.377+: shutting down, reason=crashed
>
>
>
>
Thanks! My question is, does this also reproduce with qemu 7.1
or is the problem
pci_dev name:virtio-blk-pciqemu-4.1: hw/pci/msix.c:612: msix_unset_vector_notifiers: Assertion `dev->msix_vector_use_notifier && dev->msix_vector_release_notifier' failed.2022-07-29 07:52:53.377+: shutting down, reason=crashed
----
主 题：Re: [RESEND PATCH] virtio-pci: fix vector_
On Wed, Nov 30, 2022 at 01:56:11PM +0800, leixiang wrote:
> proxy->vector_irqfd did not free when set guest notifier failed.
>
> Signed-off-by: Lei Xiang
> Tested-by: Zeng Chi
> Suggested-by: Xie Ming
Thanks a lot! Fixes tag? When was the leak introduced?
> ---
> hw/virtio/virtio-pci.c | 6
proxy->vector_irqfd did not free when set guest notifier failed.
Signed-off-by: Lei Xiang
Tested-by: Zeng Chi
Suggested-by: Xie Ming
---
hw/virtio/virtio-pci.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index c6b47a9c..4862f83b 100
proxy->vector_irqfd did not free when set guest notifier failed.
Signed-off-by: Lei Xiang
Tested-by: Zeng Chi
Suggested-by: Xie Ming
---
hw/virtio/virtio-pci.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index c6b47a9c..4862f83b 100
proxy->vector_irqfd did not free when set guest notifier failed.
Signed-off-by: Lei Xiang
Tested-by: Zeng Chi
Suggested-by: Xie Ming
---
hw/virtio/virtio-pci.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index c6b47a9c..4862f83b 100
