Re: [Qemu-devel] xhci migration breakage

2017-03-31 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > Hi, > > > dest: > > (qemu) red_dispatcher_loadvm_commands: > > usb-storage msd post_load 0x7f45f510ee50 sig=0 tag=0 > > > > I added these as debug on the 'usb-storage' vmsd element; but > > the signature/tag being 0 I assume they're not the culprit.

Re: [Qemu-devel] xhci migration breakage

2017-03-30 Thread Gerd Hoffmann
Hi, > dest: > (qemu) red_dispatcher_loadvm_commands: > usb-storage msd post_load 0x7f45f510ee50 sig=0 tag=0 > > I added these as debug on the 'usb-storage' vmsd element; but > the signature/tag being 0 I assume they're not the culprit. Yep, no inflight transfer, so highly unlikely (also note

Re: [Qemu-devel] xhci migration breakage

2017-03-30 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > Hi, > > > I guess maybe there's a kick needed pre/post migrate? > > Sure, but it is there already (post_load arms kick_timer for active > endpoints), so it isn't *that* simple. > > Looking at this I have no idea offhand, guess I have to schedule som

Re: [Qemu-devel] xhci migration breakage

2017-03-30 Thread Gerd Hoffmann
Hi, > I guess maybe there's a kick needed pre/post migrate? Sure, but it is there already (post_load arms kick_timer for active endpoints), so it isn't *that* simple. Looking at this I have no idea offhand, guess I have to schedule some debugging for tomorrow. Keep me posted in case you conti

[Qemu-devel] xhci migration breakage

2017-03-30 Thread Dr. David Alan Gilbert
Hi Gerd, 2.9 seems to have an xhci migration breakage, I've bisected it down to: commit ddb603ab6c981c1d67cb42266fc700c33e5b2d8f Author: Gerd Hoffmann Date: Mon Jan 30 16:36:46 2017 +0100 xhci: don't kick in xhci_submit and xhci_fire_ctl_transfer I guess maybe there's a kick needed pre/p