Re: [Qemu-devel] weird qdev error

2012-02-13 Thread Paolo Bonzini
On 02/13/2012 05:58 AM, Michael S. Tsirkin wrote: Doesn't solve this issue, but shouldn't we use _SAFE in object_property_del_child? Like this: ---> qemu: use safe list macro As we might remove an element from list, use the safe macro to walk it. Signed-off-by: Michael S. Tsirkin --- diff -

Re: [Qemu-devel] weird qdev error

2012-02-12 Thread Michael S. Tsirkin
On Mon, Feb 13, 2012 at 03:18:13AM +0200, Michael S. Tsirkin wrote: > > I also see this: > > > > device_add virtio-net-pci,netdev=foo,mac=52:54:00:12:34:56,id=bla > > device_del bla > > *** glibc detected *** /home/mst/qemu-test/bin/qemu-system-x86_64: > > corrupted double-linked list: 0x7fae4

Re: [Qemu-devel] weird qdev error

2012-02-12 Thread Michael S. Tsirkin
On Mon, Feb 13, 2012 at 02:17:35AM +0200, Michael S. Tsirkin wrote: > On Sun, Feb 12, 2012 at 02:19:19PM -0600, Anthony Liguori wrote: > > On 02/12/2012 02:15 PM, Michael S. Tsirkin wrote: > > >On Sun, Feb 12, 2012 at 02:04:29PM -0600, Anthony Liguori wrote: > > >>On 02/12/2012 11:57 AM, Michael S.

Re: [Qemu-devel] weird qdev error

2012-02-12 Thread Michael S. Tsirkin
On Sun, Feb 12, 2012 at 02:19:19PM -0600, Anthony Liguori wrote: > On 02/12/2012 02:15 PM, Michael S. Tsirkin wrote: > >On Sun, Feb 12, 2012 at 02:04:29PM -0600, Anthony Liguori wrote: > >>On 02/12/2012 11:57 AM, Michael S. Tsirkin wrote: > >>>On Sun, Feb 12, 2012 at 11:38:24AM -0600, Anthony Liguo

Re: [Qemu-devel] weird qdev error

2012-02-12 Thread Anthony Liguori
On 02/12/2012 02:15 PM, Michael S. Tsirkin wrote: On Sun, Feb 12, 2012 at 02:04:29PM -0600, Anthony Liguori wrote: On 02/12/2012 11:57 AM, Michael S. Tsirkin wrote: On Sun, Feb 12, 2012 at 11:38:24AM -0600, Anthony Liguori wrote: From: Anthony Liguori Date: Sun, 12 Feb 2012 11:36:24 -0600 Subj

Re: [Qemu-devel] weird qdev error

2012-02-12 Thread Michael S. Tsirkin
On Sun, Feb 12, 2012 at 02:04:29PM -0600, Anthony Liguori wrote: > On 02/12/2012 11:57 AM, Michael S. Tsirkin wrote: > >On Sun, Feb 12, 2012 at 11:38:24AM -0600, Anthony Liguori wrote: > >>From: Anthony Liguori > >>Date: Sun, 12 Feb 2012 11:36:24 -0600 > >>Subject: [PATCH] device_add: don't add a /

Re: [Qemu-devel] weird qdev error

2012-02-12 Thread Anthony Liguori
On 02/12/2012 11:57 AM, Michael S. Tsirkin wrote: On Sun, Feb 12, 2012 at 11:38:24AM -0600, Anthony Liguori wrote: From: Anthony Liguori Date: Sun, 12 Feb 2012 11:36:24 -0600 Subject: [PATCH] device_add: don't add a /peripheral link until init is complete Otherwise we end up with a dangling ref

Re: [Qemu-devel] weird qdev error

2012-02-12 Thread Michael S. Tsirkin
On Sun, Feb 12, 2012 at 11:38:24AM -0600, Anthony Liguori wrote: > On 02/12/2012 11:31 AM, Michael S. Tsirkin wrote: > >On Sun, Feb 12, 2012 at 07:07:43PM +0200, Michael S. Tsirkin wrote: > >>I got this assert when working on qemu: pci hotplug > >>callback failed so qdev_free was called. > >> > >>(

Re: [Qemu-devel] weird qdev error

2012-02-12 Thread Anthony Liguori
On 02/12/2012 11:31 AM, Michael S. Tsirkin wrote: On Sun, Feb 12, 2012 at 07:07:43PM +0200, Michael S. Tsirkin wrote: I got this assert when working on qemu: pci hotplug callback failed so qdev_free was called. (gdb) where #0 0x75fa1905 in raise () from /lib64/libc.so.6 #1 0x7

Re: [Qemu-devel] weird qdev error

2012-02-12 Thread Michael S. Tsirkin
On Sun, Feb 12, 2012 at 07:07:43PM +0200, Michael S. Tsirkin wrote: > I got this assert when working on qemu: pci hotplug > callback failed so qdev_free was called. > > (gdb) where > #0 0x75fa1905 in raise () from /lib64/libc.so.6 > #1 0x75fa30e5 in abort () from /lib64/libc.so.6

[Qemu-devel] weird qdev error

2012-02-12 Thread Michael S. Tsirkin
I got this assert when working on qemu: pci hotplug callback failed so qdev_free was called. (gdb) where #0 0x75fa1905 in raise () from /lib64/libc.so.6 #1 0x75fa30e5 in abort () from /lib64/libc.so.6 #2 0x77413a7f in g_assertion_message () from /lib64/libglib-2.0.so.0 #