Benjamin Herrenschmidt writes:
> Hi Anthony !
>
> I was looking at virtio-blk.c as an example of some details regarding
> the use of virtio queues. One thing I'm implementing is a
> request/reponse model similar to what it does.
>
> One thing I noticed that sounds off to me but I might have misse
On Wed, Aug 1, 2012 at 11:27 AM, Benjamin Herrenschmidt
wrote:
> On Wed, 2012-08-01 at 11:16 +0100, Stefan Hajnoczi wrote:
>
>> The len field is mostly informational. The virtio device driver
>> inside the guest may make use of it. In many cases it doesn't so an
>> incorrect len value has no eff
On Wed, 2012-08-01 at 11:16 +0100, Stefan Hajnoczi wrote:
> The len field is mostly informational. The virtio device driver
> inside the guest may make use of it. In many cases it doesn't so an
> incorrect len value has no effect. In
> drivers/block/virtio_blk.c:blk_done() the len variable is u
On Wed, Aug 1, 2012 at 5:54 AM, Benjamin Herrenschmidt
wrote:
> However, virtio_blk_req_complete() does:
>
> virtqueue_push(s->vq, &req->elem, req->qiov.size + sizeof(*req->in));
>
> So it pushes into the queue req->qiov.size (which is 0) + sizeof(*req->in)
> which is as far as I can tell ...
Hi Anthony !
I was looking at virtio-blk.c as an example of some details regarding
the use of virtio queues. One thing I'm implementing is a
request/reponse model similar to what it does.
One thing I noticed that sounds off to me but I might have missed
something is the handling of the "GET_ID" r
