Re: [Qemu-devel] vhost_net.c broken by --kerneldir

2010-09-03 Thread Michael S. Tsirkin
On Thu, Aug 26, 2010 at 05:15:35PM +0200, Arnd Bergmann wrote: > On Wednesday 25 August 2010, Hollis Blanchard wrote: > > > We only recently fixed the kernel to have this warning in types.h, which > > > triggers more often than kernel.h, where it used to be before. In 2.6.35 > > > and before, you c

Re: [Qemu-devel] vhost_net.c broken by --kerneldir

2010-08-26 Thread Anthony Liguori
On 08/26/2010 11:41 AM, Hollis Blanchard wrote: On 08/26/2010 08:48 AM, Anthony Liguori wrote: On 08/26/2010 10:21 AM, Gleb Natapov wrote: You forgot about developers. Developer may want to use latest kvm kernel headers to compile code that he added to qemu to use new kernel feature. The Rig

Re: [Qemu-devel] vhost_net.c broken by --kerneldir

2010-08-26 Thread Hollis Blanchard
On 08/26/2010 08:48 AM, Anthony Liguori wrote: On 08/26/2010 10:21 AM, Gleb Natapov wrote: You forgot about developers. Developer may want to use latest kvm kernel headers to compile code that he added to qemu to use new kernel feature. The Right Way to do this is a make headers_install to a t

Re: [Qemu-devel] vhost_net.c broken by --kerneldir

2010-08-26 Thread Arnd Bergmann
On Thursday 26 August 2010, Gleb Natapov wrote: > You forgot about developers. Developer may want to use latest kvm kernel > headers to compile code that he added to qemu to use new kernel feature. In that case, you already need to install the kernel in order to test it, so you might as well insta

Re: [Qemu-devel] vhost_net.c broken by --kerneldir

2010-08-26 Thread Anthony Liguori
On 08/26/2010 10:21 AM, Gleb Natapov wrote: You forgot about developers. Developer may want to use latest kvm kernel headers to compile code that he added to qemu to use new kernel feature. The Right Way to do this is a make headers_install to a temporary directory and then -I include that

Re: [Qemu-devel] vhost_net.c broken by --kerneldir

2010-08-26 Thread Gleb Natapov
On Thu, Aug 26, 2010 at 05:15:35PM +0200, Arnd Bergmann wrote: > On Wednesday 25 August 2010, Hollis Blanchard wrote: > > > We only recently fixed the kernel to have this warning in types.h, which > > > triggers more often than kernel.h, where it used to be before. In 2.6.35 > > > and before, you c

Re: [Qemu-devel] vhost_net.c broken by --kerneldir

2010-08-26 Thread Arnd Bergmann
On Wednesday 25 August 2010, Hollis Blanchard wrote: > > We only recently fixed the kernel to have this warning in types.h, which > > triggers more often than kernel.h, where it used to be before. In 2.6.35 > > and before, you consequently would not have noticed the problem. > > > > Thanks Arn

Re: [Qemu-devel] vhost_net.c broken by --kerneldir

2010-08-25 Thread Hollis Blanchard
On 08/25/2010 06:37 AM, Arnd Bergmann wrote: On Wednesday 25 August 2010, Hollis Blanchard wrote: The problem seems to be that jump from /usr/include/bits/sigcontext.h to asm/sigcontext.h inside rather than inside /usr/include. It seems like adding -Ikerneldir/arch/foo/include will always b

Re: [Qemu-devel] vhost_net.c broken by --kerneldir

2010-08-25 Thread Arnd Bergmann
On Wednesday 25 August 2010, Hollis Blanchard wrote: > The problem seems to be that jump from /usr/include/bits/sigcontext.h to > asm/sigcontext.h inside rather than inside /usr/include. It > seems like adding -Ikerneldir/arch/foo/include will always be a problem, > since it will always be use

[Qemu-devel] vhost_net.c broken by --kerneldir

2010-08-24 Thread Hollis Blanchard
I'm scratching my head on this one, but here's my problem: % ./configure --target-list=x86_64-softmmu --kerneldir=/home/hollisb/work/linux-2.6.hg % make V=1 [...] gcc -I/home/hollisb/work/qemu.git/slirp -Werror -m32 -fstack-protector-all -Wold-style-definition -Wold-style-declaration -I. -I/ho