Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-26 Thread Nikolay Nikolaev
On Thu, Jun 26, 2014 at 12:37 AM, Damjan Marion (damarion) wrote: > > On 25 Jun 2014, at 20:18, Michael S. Tsirkin wrote: > >> On Wed, Jun 25, 2014 at 09:13:36PM +0300, Nikolay Nikolaev wrote: >>> On Wed, Jun 25, 2014 at 9:07 PM, Michael S. Tsirkin wrote: On Wed, Jun 25, 2014 at 07:56:46PM

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-26 Thread Damjan Marion (damarion)
On 26 Jun 2014, at 09:56, Michael S. Tsirkin wrote: > On Thu, Jun 26, 2014 at 07:44:24AM +, Damjan Marion (damarion) wrote: >> >> On 26 Jun 2014, at 09:13, Michael S. Tsirkin wrote: >> >>> On Wed, Jun 25, 2014 at 09:52:09PM +, Damjan Marion (damarion) wrote: On 25 Jun 2014,

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-26 Thread Michael S. Tsirkin
On Thu, Jun 26, 2014 at 07:44:24AM +, Damjan Marion (damarion) wrote: > > On 26 Jun 2014, at 09:13, Michael S. Tsirkin wrote: > > > On Wed, Jun 25, 2014 at 09:52:09PM +, Damjan Marion (damarion) wrote: > >> > >> On 25 Jun 2014, at 18:44, Paolo Bonzini wrote: > >> > nregions: 4 >

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-26 Thread Damjan Marion (damarion)
On 26 Jun 2014, at 09:13, Michael S. Tsirkin wrote: > On Wed, Jun 25, 2014 at 09:52:09PM +, Damjan Marion (damarion) wrote: >> >> On 25 Jun 2014, at 18:44, Paolo Bonzini wrote: >> nregions: 4 region: gpa = 0x1 size = 3221225472 ua = 0x2aab6ac0

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-26 Thread Michael S. Tsirkin
On Wed, Jun 25, 2014 at 09:52:09PM +, Damjan Marion (damarion) wrote: > > On 25 Jun 2014, at 18:44, Paolo Bonzini wrote: > > >> nregions: 4 > >> region: > >>gpa = 0x1 > >>size = 3221225472 > >>ua = 0x2aab6ac0 > > > > High memory, above 3 gigabytes. > > > >> region:

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Damjan Marion (damarion)
On 25 Jun 2014, at 18:44, Paolo Bonzini wrote: >> nregions: 4 >> region: >> gpa = 0x1 >> size = 3221225472 >> ua = 0x2aab6ac0 > > High memory, above 3 gigabytes. > >> region: >> gpa = 0xFFFC >> size = 262144 >> ua = 0x7fc13d20 > > This is the

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Damjan Marion (damarion)
On 25 Jun 2014, at 20:18, Michael S. Tsirkin wrote: > On Wed, Jun 25, 2014 at 09:13:36PM +0300, Nikolay Nikolaev wrote: >> On Wed, Jun 25, 2014 at 9:07 PM, Michael S. Tsirkin wrote: >>> On Wed, Jun 25, 2014 at 07:56:46PM +0300, Nikolay Nikolaev wrote: On Wed, Jun 25, 2014 at 7:44 PM, Paolo

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Michael S. Tsirkin
On Wed, Jun 25, 2014 at 09:13:36PM +0300, Nikolay Nikolaev wrote: > On Wed, Jun 25, 2014 at 9:07 PM, Michael S. Tsirkin wrote: > > On Wed, Jun 25, 2014 at 07:56:46PM +0300, Nikolay Nikolaev wrote: > >> On Wed, Jun 25, 2014 at 7:44 PM, Paolo Bonzini wrote: > >> >> nregions: 4 > >> >> region: > >>

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Nikolay Nikolaev
On Wed, Jun 25, 2014 at 9:07 PM, Michael S. Tsirkin wrote: > On Wed, Jun 25, 2014 at 07:56:46PM +0300, Nikolay Nikolaev wrote: >> On Wed, Jun 25, 2014 at 7:44 PM, Paolo Bonzini wrote: >> >> nregions: 4 >> >> region: >> >> gpa = 0x1 >> >> size = 3221225472 >> >> ua = 0x2a

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Michael S. Tsirkin
On Wed, Jun 25, 2014 at 07:05:08PM +0200, Paolo Bonzini wrote: > Il 25/06/2014 18:56, Nikolay Nikolaev ha scritto: > >>> I understand now what you mean. Yeah, the format should be changed > >>> to include the offset (why does vhost-user need the ua at all? > >The vring addresses are QEMU UA addres

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Michael S. Tsirkin
On Wed, Jun 25, 2014 at 07:56:46PM +0300, Nikolay Nikolaev wrote: > On Wed, Jun 25, 2014 at 7:44 PM, Paolo Bonzini wrote: > >> nregions: 4 > >> region: > >> gpa = 0x1 > >> size = 3221225472 > >> ua = 0x2aab6ac0 > > > > High memory, above 3 gigabytes. > > > >> region:

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Paolo Bonzini
Il 25/06/2014 19:06, Nikolay Nikolaev ha scritto: > I understand now what you mean. Yeah, the format should be changed > to include the offset (why does vhost-user need the ua at all? > perhaps the offset can replace the ua). I am trying to do the math here. So if this file is mapped by QEMU in

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Nikolay Nikolaev
On Wed, Jun 25, 2014 at 7:44 PM, Paolo Bonzini wrote: >> nregions: 4 >> region: >> gpa = 0x1 >> size = 3221225472 >> ua = 0x2aab6ac0 > > High memory, above 3 gigabytes. > >> region: >> gpa = 0xFFFC >> size = 262144 >> ua = 0x7fc13d20 > > This

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Paolo Bonzini
Il 25/06/2014 18:56, Nikolay Nikolaev ha scritto: > I understand now what you mean. Yeah, the format should be changed > to include the offset (why does vhost-user need the ua at all? The vring addresses are QEMU UA addresses. Of course vhost-user can translate them to guest physical before sen

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Nikolay Nikolaev
On Wed, Jun 25, 2014 at 7:44 PM, Paolo Bonzini wrote: >> nregions: 4 >> region: >> gpa = 0x1 >> size = 3221225472 >> ua = 0x2aab6ac0 > > High memory, above 3 gigabytes. > >> region: >> gpa = 0xFFFC >> size = 262144 >> ua = 0x7fc13d20 > > This

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Paolo Bonzini
> nregions: 4 > region: > gpa = 0x1 > size = 3221225472 > ua = 0x2aab6ac0 High memory, above 3 gigabytes. > region: > gpa = 0xFFFC > size = 262144 > ua = 0x7fc13d20 This is the BIOS. There shouldn't be any FD for this one, it is not alloca

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Damjan Marion (damarion)
On 25 Jun 2014, at 17:50, Michael S. Tsirkin wrote: > On Wed, Jun 25, 2014 at 03:46:04PM +, Damjan Marion (damarion) wrote: >> >> On 25 Jun 2014, at 17:29, Michael S. Tsirkin wrote: >> >>> On Wed, Jun 25, 2014 at 02:57:52PM +, Damjan Marion (damarion) wrote: On 25 Jun 2014,

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Damjan Marion (damarion)
On 25 Jun 2014, at 17:29, Michael S. Tsirkin wrote: > On Wed, Jun 25, 2014 at 02:57:52PM +, Damjan Marion (damarion) wrote: >> >> On 25 Jun 2014, at 16:27, Michael S. Tsirkin wrote: >> >>> On Wed, Jun 25, 2014 at 02:20:56PM +, Damjan Marion (damarion) wrote: On 25 Jun 2014,

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Michael S. Tsirkin
On Wed, Jun 25, 2014 at 03:46:04PM +, Damjan Marion (damarion) wrote: > > On 25 Jun 2014, at 17:29, Michael S. Tsirkin wrote: > > > On Wed, Jun 25, 2014 at 02:57:52PM +, Damjan Marion (damarion) wrote: > >> > >> On 25 Jun 2014, at 16:27, Michael S. Tsirkin wrote: > >> > >>> On Wed, Ju

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Michael S. Tsirkin
On Wed, Jun 25, 2014 at 02:57:52PM +, Damjan Marion (damarion) wrote: > > On 25 Jun 2014, at 16:27, Michael S. Tsirkin wrote: > > > On Wed, Jun 25, 2014 at 02:20:56PM +, Damjan Marion (damarion) wrote: > >> > >> On 25 Jun 2014, at 16:13, Nikolay Nikolaev > >> wrote: > >> > > - it

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Damjan Marion (damarion)
On 25 Jun 2014, at 16:27, Michael S. Tsirkin wrote: > On Wed, Jun 25, 2014 at 02:20:56PM +, Damjan Marion (damarion) wrote: >> >> On 25 Jun 2014, at 16:13, Nikolay Nikolaev >> wrote: >> > - it will require changes on the user side also why would it? format seems uncha

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Michael S. Tsirkin
On Wed, Jun 25, 2014 at 02:20:56PM +, Damjan Marion (damarion) wrote: > > On 25 Jun 2014, at 16:13, Nikolay Nikolaev > wrote: > > > >> - it will require changes on the user side also > > > > > > why would it? > > > format seems unchanged, right? > > > > yes, but it will happen that multipl

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Damjan Marion (damarion)
On 25 Jun 2014, at 16:13, Nikolay Nikolaev wrote: > >> - it will require changes on the user side also > > > > why would it? > > format seems unchanged, right? > > yes, but it will happen that multiple regions have same FD so call to mmap() > should look different, I’m still playing with this

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Damjan Marion (damarion)
On 25 Jun 2014, at 16:06, Nikolay Nikolaev wrote: > +msg.memory.regions[fd_num].memory_size = reg->memory_size; > so this is size > +msg.memory.regions[fd_num].guest_phys_addr = > reg->memory_size; > and this is size again? mistake, i alredy noticed it. It

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Michael S. Tsirkin
On Wed, Jun 25, 2014 at 05:13:21PM +0300, Nikolay Nikolaev wrote: > > > > On Wed, Jun 25, 2014 at 5:06 PM, Damjan Marion (damarion) > wrote: > > > On 25 Jun 2014, at 15:53, Michael S. Tsirkin wrote: > > > On Wed, Jun 25, 2014 at 01:45:09PM +, Damjan Marion (damarion) > wrote: >

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Nikolay Nikolaev
On Wed, Jun 25, 2014 at 5:06 PM, Damjan Marion (damarion) < damar...@cisco.com> wrote: > > On 25 Jun 2014, at 15:53, Michael S. Tsirkin wrote: > > > On Wed, Jun 25, 2014 at 01:45:09PM +, Damjan Marion (damarion) wrote: > >> > >> Michael, > >> > >> there is another issue with commited vhost-us

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Damjan Marion (damarion)
On 25 Jun 2014, at 15:53, Michael S. Tsirkin wrote: > On Wed, Jun 25, 2014 at 01:45:09PM +, Damjan Marion (damarion) wrote: >> >> Michael, >> >> there is another issue with commited vhost-user code. > > I'm answering just this once, but I have a policy against > answering off-list mail. >