Re: [Qemu-devel] sheepdog build warning

2018-12-18 Thread Daniel P . Berrangé
On Mon, Dec 17, 2018 at 11:16:05PM -0500, Michael S. Tsirkin wrote: > On Mon, Dec 17, 2018 at 11:03:11PM -0500, Michael S. Tsirkin wrote: > > mingw32 build on fedora fails with this warning: > > > > /scm/qemu/block/sheepdog.c: In function 'find_vdi_name': > > /scm/qemu/block/sheepdog.c:1239:5: err

Re: [Qemu-devel] sheepdog build warning

2018-12-18 Thread Philippe Mathieu-Daudé
Hi Michael, On 12/18/18 5:16 AM, Michael S. Tsirkin wrote: > On Mon, Dec 17, 2018 at 11:03:11PM -0500, Michael S. Tsirkin wrote: >> mingw32 build on fedora fails with this warning: >> >> /scm/qemu/block/sheepdog.c: In function 'find_vdi_name': >> /scm/qemu/block/sheepdog.c:1239:5: error: 'strncpy'

Re: [Qemu-devel] sheepdog build warning

2018-12-17 Thread Michael S. Tsirkin
On Mon, Dec 17, 2018 at 11:03:11PM -0500, Michael S. Tsirkin wrote: > mingw32 build on fedora fails with this warning: > > /scm/qemu/block/sheepdog.c: In function 'find_vdi_name': > /scm/qemu/block/sheepdog.c:1239:5: error: 'strncpy' specified bound 256 > equals destination size [-Werror=stringop

[Qemu-devel] sheepdog build warning

2018-12-17 Thread Michael S. Tsirkin
mingw32 build on fedora fails with this warning: /scm/qemu/block/sheepdog.c: In function 'find_vdi_name': /scm/qemu/block/sheepdog.c:1239:5: error: 'strncpy' specified bound 256 equals destination size [-Werror=stringop-truncation] strncpy(buf + SD_MAX_VDI_LEN, tag, SD_MAX_VDI_TAG_LEN);