Re: [Qemu-devel] s390 tcg breakage

2013-03-25 Thread Richard Henderson
On 2013-03-25 06:19, Alexander Graf wrote: This is because lgfi leaves the register negative, but iihl doesn't replace the upper 16 bits, only [48..32]. The patch below fixes it for me, but I'm sure you can come up with something cleaner, better and working on non-ext-imm machines :). Oops,

[Qemu-devel] s390 tcg breakage

2013-03-25 Thread Alexander Graf
Hi Richard, I've finally gotten around to debug why TCG on s390 hosts breaks for me. The reason turned out to be quite simple. The broken TB ends with a goto_tb instruction: exit_tb $0x3fffb258010 which gets translated into: 0x9040: lgfi%r2,-81428464 0x9046: iihl%r2