Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-26 Thread Georgi Guninski
On Mon, Jun 25, 2018 at 09:27:59AM +0200, Christian Borntraeger wrote: > -/* Overwrite parameters in the kernel image, which are "rom" */ > -strcpy(rom_ptr(KERN_PARM_AREA), ipl->cmdline); > +strcpy(rom_ptr(KERN_PARM_AREA), ipl->cmdline); Why not replace strcpy(

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-26 Thread Christian Borntraeger
On 06/26/2018 10:29 AM, Cornelia Huck wrote: [...] if (ipl->initrd) { ram_addr_t initrd_offset; would put the command line in no matter what the start address is. >>> >>> I'm for putting that one in (and backporting it to qemu-stable). It's a >>

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-26 Thread Cornelia Huck
On Mon, 25 Jun 2018 10:29:46 +0200 Christian Borntraeger wrote: > On 06/25/2018 10:05 AM, Cornelia Huck wrote: > > On Mon, 25 Jun 2018 09:27:59 +0200 > > Christian Borntraeger wrote: > >> Something like this in QEMU > >> > >> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c > >> index f278036fa7..

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Thomas Huth
On 26.06.2018 07:32, Georgi Guninski wrote: > On Mon, Jun 25, 2018 at 09:27:59AM +0200, Christian Borntraeger wrote: >> -/* Overwrite parameters in the kernel image, which are "rom" */ >> -strcpy(rom_ptr(KERN_PARM_AREA), ipl->cmdline); > >> +strcpy(rom_ptr(KERN_

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Vasily Gorbik
On Mon, Jun 25, 2018 at 06:35:30AM -0700, Guenter Roeck wrote: > On 06/25/2018 05:26 AM, Christian Borntraeger wrote: > > > > > > On 06/25/2018 10:49 AM, Cornelia Huck wrote: > > > On Mon, 25 Jun 2018 10:36:33 +0200 > > > Vasily Gorbik wrote: > > > > > > > This change has been done on purpose.

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Guenter Roeck
On 06/25/2018 05:26 AM, Christian Borntraeger wrote: On 06/25/2018 10:49 AM, Cornelia Huck wrote: On Mon, 25 Jun 2018 10:36:33 +0200 Vasily Gorbik wrote: This change has been done on purpose. Uncompressed image is not going to be bootable any more. In future the decompressor phase would get

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Vasily Gorbik
This change has been done on purpose. Uncompressed image is not going to be bootable any more. In future the decompressor phase would get more function (early memory detection as an example) and there is no chance to duplicate that code in uncompressed image as well (to keep it bootable on its own)

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Christian Borntraeger
On 06/25/2018 10:49 AM, Cornelia Huck wrote: > On Mon, 25 Jun 2018 10:36:33 +0200 > Vasily Gorbik wrote: > >> This change has been done on purpose. Uncompressed image is not going >> to be bootable any more. In future the decompressor phase would get >> more function (early memory detection as

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Cornelia Huck
On Mon, 25 Jun 2018 10:36:33 +0200 Vasily Gorbik wrote: > This change has been done on purpose. Uncompressed image is not going > to be bootable any more. In future the decompressor phase would get > more function (early memory detection as an example) and there is no > chance to duplicate that c

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Christian Borntraeger
On 06/25/2018 10:05 AM, Cornelia Huck wrote: > On Mon, 25 Jun 2018 09:27:59 +0200 > Christian Borntraeger wrote: > >> Also adding QEMU. >> >> On 06/25/2018 09:10 AM, Christian Borntraeger wrote: >>> >>> >>> On 06/22/2018 09:47 PM, Guenter Roeck wrote: Hi, starting with commit

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Cornelia Huck
On Mon, 25 Jun 2018 09:27:59 +0200 Christian Borntraeger wrote: > Also adding QEMU. > > On 06/25/2018 09:10 AM, Christian Borntraeger wrote: > > > > > > On 06/22/2018 09:47 PM, Guenter Roeck wrote: > >> Hi, > >> > >> starting with commit 's390/boot: make head.S and als.c be part of the > >>

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Christian Borntraeger
Also adding QEMU. On 06/25/2018 09:10 AM, Christian Borntraeger wrote: > > > On 06/22/2018 09:47 PM, Guenter Roeck wrote: >> Hi, >> >> starting with commit 's390/boot: make head.S and als.c be part of the >> decompressor only' in -next, s390 immages no longer boot in qemu. >> As far as I can see