Re: [Qemu-devel] qemu_system_reset_request() broken w.r.t BQL locking regime

2017-07-06 Thread Alex Bennée
Paolo Bonzini writes: > On 05/07/2017 18:14, Peter Maydell wrote: >>> - Guest resets board, writing to some hw address (e.g. >>> arm_sysctl_write) >>> - This triggers qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET) >>> - We exit iowrite and drop the BQL >>> - vl.c schedules qem

Re: [Qemu-devel] qemu_system_reset_request() broken w.r.t BQL locking regime

2017-07-05 Thread Alex Bennée
Peter Maydell writes: > On 5 July 2017 at 20:30, Alex Bennée wrote: >> >> Peter Maydell writes: >> >>> On 5 July 2017 at 17:01, Alex Bennée wrote: An interesting bug was reported on #qemu today. It was bisected to 8d04fb55 (drop global lock for TCG) and only occurred when QEMU was r

Re: [Qemu-devel] qemu_system_reset_request() broken w.r.t BQL locking regime

2017-07-05 Thread Alex Bennée
Peter Maydell writes: > On 5 July 2017 at 20:30, Alex Bennée wrote: >> >> Peter Maydell writes: >> >>> On 5 July 2017 at 17:01, Alex Bennée wrote: An interesting bug was reported on #qemu today. It was bisected to 8d04fb55 (drop global lock for TCG) and only occurred when QEMU was r

Re: [Qemu-devel] qemu_system_reset_request() broken w.r.t BQL locking regime

2017-07-05 Thread Peter Maydell
On 5 July 2017 at 20:30, Alex Bennée wrote: > > Peter Maydell writes: > >> On 5 July 2017 at 17:01, Alex Bennée wrote: >>> An interesting bug was reported on #qemu today. It was bisected to >>> 8d04fb55 (drop global lock for TCG) and only occurred when QEMU was run >>> with taskset -c 0. Origina

Re: [Qemu-devel] qemu_system_reset_request() broken w.r.t BQL locking regime

2017-07-05 Thread Alex Bennée
Paolo Bonzini writes: > On 05/07/2017 18:14, Peter Maydell wrote: >>> - Guest resets board, writing to some hw address (e.g. >>> arm_sysctl_write) >>> - This triggers qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET) >>> - We exit iowrite and drop the BQL >>> - vl.c schedules qem

Re: [Qemu-devel] qemu_system_reset_request() broken w.r.t BQL locking regime

2017-07-05 Thread Alex Bennée
Peter Maydell writes: > On 5 July 2017 at 17:01, Alex Bennée wrote: >> An interesting bug was reported on #qemu today. It was bisected to >> 8d04fb55 (drop global lock for TCG) and only occurred when QEMU was run >> with taskset -c 0. Originally the fingers where pointed at mttcg but it >> occu

Re: [Qemu-devel] qemu_system_reset_request() broken w.r.t BQL locking regime

2017-07-05 Thread G 3
On Jul 5, 2017, at 12:42 PM, qemu-devel-requ...@nongnu.org wrote: Hi, An interesting bug was reported on #qemu today. It was bisected to 8d04fb55 (drop global lock for TCG) and only occurred when QEMU was run with taskset -c 0. Originally the fingers where pointed at mttcg but it occurs i

Re: [Qemu-devel] qemu_system_reset_request() broken w.r.t BQL locking regime

2017-07-05 Thread Paolo Bonzini
On 05/07/2017 18:14, Peter Maydell wrote: >> - Guest resets board, writing to some hw address (e.g. >> arm_sysctl_write) >> - This triggers qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET) >> - We exit iowrite and drop the BQL >> - vl.c schedules qemu_system_reset->qemu_devices_r

Re: [Qemu-devel] qemu_system_reset_request() broken w.r.t BQL locking regime

2017-07-05 Thread Peter Maydell
On 5 July 2017 at 17:01, Alex Bennée wrote: > An interesting bug was reported on #qemu today. It was bisected to > 8d04fb55 (drop global lock for TCG) and only occurred when QEMU was run > with taskset -c 0. Originally the fingers where pointed at mttcg but it > occurs in both single and multi-thr

[Qemu-devel] qemu_system_reset_request() broken w.r.t BQL locking regime

2017-07-05 Thread Alex Bennée
Hi, An interesting bug was reported on #qemu today. It was bisected to 8d04fb55 (drop global lock for TCG) and only occurred when QEMU was run with taskset -c 0. Originally the fingers where pointed at mttcg but it occurs in both single and multi-threaded modes. I think the problem is qemu_syste