Re: [Qemu-devel] qemu and transparent huge pages

2012-11-13 Thread Michael Tokarev
On 13.11.2012 18:30, Aurelien Jarno wrote: > Isn't ad0b5321f1f797274603ebbe20108b0750baee94 enough? Oh. It has been applied. I expected it will be ignored just like my patch has been. No, it is not enough: that patch alone does nothing for the alignment on at least x86, which is necessary for h

Re: [Qemu-devel] qemu and transparent huge pages

2012-11-13 Thread Aurelien Jarno
Isn't ad0b5321f1f797274603ebbe20108b0750baee94 enough? On Mon, Nov 12, 2012 at 07:18:49PM +0400, Michael Tokarev wrote: > Ping^2 ? > > Thanks, > > /mjt > > 16.09.2012 15:19, Michael Tokarev wrote: > > So, is the patch okay? > > > > Thanks, > > > > /mjt > > > > On 15.08.2012 19:03, Michael To

Re: [Qemu-devel] qemu and transparent huge pages

2012-11-12 Thread Michael Tokarev
Ping^2 ? Thanks, /mjt 16.09.2012 15:19, Michael Tokarev wrote: > So, is the patch okay? > > Thanks, > > /mjt > > On 15.08.2012 19:03, Michael Tokarev wrote: >> On 15.08.2012 18:26, Avi Kivity wrote: >>> On 08/15/2012 05:22 PM, Michael Tokarev wrote: >>> > > Please provide extra info,

Re: [Qemu-devel] qemu and transparent huge pages

2012-09-16 Thread Michael Tokarev
So, is the patch okay? Thanks, /mjt On 15.08.2012 19:03, Michael Tokarev wrote: > On 15.08.2012 18:26, Avi Kivity wrote: >> On 08/15/2012 05:22 PM, Michael Tokarev wrote: >> Please provide extra info, like the setting of /sys/kernel/mm/transparent_hugepage/enabled. >>> >>> That wa

Re: [Qemu-devel] qemu and transparent huge pages

2012-08-15 Thread Michael Tokarev
On 15.08.2012 19:03, Michael Tokarev wrote: > +#ifdef MADV_HUGEPAGE > +#error Heh. This #error shouldn't be here ofcourse, I were checking if we really getting there. > +qemu_madvise(ptr, size, MADV_HUGEPAGE); > +#endif

Re: [Qemu-devel] qemu and transparent huge pages

2012-08-15 Thread Michael Tokarev
On 15.08.2012 18:26, Avi Kivity wrote: > On 08/15/2012 05:22 PM, Michael Tokarev wrote: > >>> >>> Please provide extra info, like the setting of >>> /sys/kernel/mm/transparent_hugepage/enabled. >> >> That was it - sort of. Default value here is enabled=madvise. >> When setting it to always the ef

Re: [Qemu-devel] qemu and transparent huge pages

2012-08-15 Thread Avi Kivity
On 08/15/2012 05:22 PM, Michael Tokarev wrote: >> >> Please provide extra info, like the setting of >> /sys/kernel/mm/transparent_hugepage/enabled. > > That was it - sort of. Default value here is enabled=madvise. > When setting it to always the effect finally started appearing, > so it is actu

Re: [Qemu-devel] qemu and transparent huge pages

2012-08-15 Thread Michael Tokarev
On 15.08.2012 16:51, Avi Kivity wrote: > On 08/15/2012 03:45 PM, Michael Tokarev wrote: >> >> But apparently, THP does not work still, even with 2Mb >> alignment: when running a guest, AnonHugePages in >> /proc/meminfo stays at 0 - either in kvm mode or in tcg >> mode. Any idea why? What else is

Re: [Qemu-devel] qemu and transparent huge pages

2012-08-15 Thread Avi Kivity
On 08/15/2012 03:45 PM, Michael Tokarev wrote: > > But apparently, THP does not work still, even with 2Mb > alignment: when running a guest, AnonHugePages in > /proc/meminfo stays at 0 - either in kvm mode or in tcg > mode. Any idea why? What else is needed for THP to work? It does for me: Ano

[Qemu-devel] qemu and transparent huge pages

2012-08-15 Thread Michael Tokarev
[Reposting with the right email address of Andrea] Quite some time ago there was a thread on qemu-devel, started by Andrea, about modifying qemu to better use transparent huge pages: http://lists.gnu.org/archive/html/qemu-devel/2010-03/msg01250.html That thread hasn't reached any conclusion, bu

[Qemu-devel] qemu and transparent huge pages

2012-08-15 Thread Michael Tokarev
Quite some time ago there was a thread on qemu-devel, started by Andrea, about modifying qemu to better use transparent huge pages: http://lists.gnu.org/archive/html/qemu-devel/2010-03/msg01250.html That thread hasn't reached any conclusion, but some time after that Avi implemented a similar cha