Re: [Qemu-devel] qdev property listing broken

2012-04-03 Thread Paolo Bonzini
Il 03/04/2012 00:27, Peter Maydell ha scritto: > On 2 April 2012 23:03, Paolo Bonzini wrote: >> Il 02/04/2012 22:07, Peter Maydell ha scritto: >>> On 2 April 2012 20:40, Paolo Bonzini wrote: diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c index a310cc7..923519c 100644 --- a/hw/q

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Jan Kiszka
On 2012-04-02 21:40, Paolo Bonzini wrote: > diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c > index a310cc7..923519c 100644 > --- a/hw/qdev-monitor.c > +++ b/hw/qdev-monitor.c > @@ -157,7 +157,7 @@ int qdev_device_help(QemuOpts *opts) > * for removal. This conditional should be remove

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Peter Maydell
On 2 April 2012 23:03, Paolo Bonzini wrote: > Il 02/04/2012 22:07, Peter Maydell ha scritto: >> On 2 April 2012 20:40, Paolo Bonzini wrote: >>> diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c >>> index a310cc7..923519c 100644 >>> --- a/hw/qdev-monitor.c >>> +++ b/hw/qdev-monitor.c >>> @@ -157,

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Paolo Bonzini
Il 02/04/2012 22:07, Peter Maydell ha scritto: > On 2 April 2012 20:40, Paolo Bonzini wrote: >> diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c >> index a310cc7..923519c 100644 >> --- a/hw/qdev-monitor.c >> +++ b/hw/qdev-monitor.c >> @@ -157,7 +157,7 @@ int qdev_device_help(QemuOpts *opts) >>

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Anthony Liguori
On 04/02/2012 03:07 PM, Jan Kiszka wrote: On 2012-04-02 21:41, Anthony Liguori wrote: Is there a reason you're using info qtree instead of qom-list? qom-list gives you much more info than info qtree. BTW, the qom-list output is still, well, sparsely populated. Also, there is a "-r" (for recur

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Peter Maydell
On 2 April 2012 20:40, Paolo Bonzini wrote: > diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c > index a310cc7..923519c 100644 > --- a/hw/qdev-monitor.c > +++ b/hw/qdev-monitor.c > @@ -157,7 +157,7 @@ int qdev_device_help(QemuOpts *opts) >          * for removal.  This conditional should be remo

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Jan Kiszka
On 2012-04-02 21:41, Anthony Liguori wrote: > Is there a reason you're using info qtree instead of qom-list? qom-list > gives you much more info than info qtree. BTW, the qom-list output is still, well, sparsely populated. Also, there is a "-r" (for recursive) switch missing to make it similar us

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Jan Kiszka
On 2012-04-02 21:48, Anthony Liguori wrote: > On 04/02/2012 02:44 PM, Jan Kiszka wrote: >> On 2012-04-02 21:41, Anthony Liguori wrote: >>> On 04/02/2012 02:33 PM, Jan Kiszka wrote: Hi Anthony, I noticed that only properties with legacy names are printed via info qtree. >>> >>> Y

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Anthony Liguori
On 04/02/2012 02:44 PM, Jan Kiszka wrote: On 2012-04-02 21:41, Anthony Liguori wrote: On 04/02/2012 02:33 PM, Jan Kiszka wrote: Hi Anthony, I noticed that only properties with legacy names are printed via info qtree. Yes. Is that not what you expect? The qom properties and model is not sta

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Jan Kiszka
On 2012-04-02 21:41, Anthony Liguori wrote: > On 04/02/2012 02:33 PM, Jan Kiszka wrote: >> Hi Anthony, >> >> I noticed that only properties with legacy names are printed via info >> qtree. > > Yes. Is that not what you expect? > > The qom properties and model is not stable for 1.1 so I was very

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Anthony Liguori
On 04/02/2012 02:40 PM, Paolo Bonzini wrote: Il 02/04/2012 21:33, Jan Kiszka ha scritto: Hi Anthony, I noticed that only properties with legacy names are printed via info qtree. After digging through the qdev and qom property maze, it turned out the property registration in qdev_property_add_le

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Anthony Liguori
On 04/02/2012 02:33 PM, Jan Kiszka wrote: Hi Anthony, I noticed that only properties with legacy names are printed via info qtree. Yes. Is that not what you expect? The qom properties and model is not stable for 1.1 so I was very careful in making sure they didn't leak into info qtree. A

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Paolo Bonzini
Il 02/04/2012 21:33, Jan Kiszka ha scritto: > Hi Anthony, > > I noticed that only properties with legacy names are printed via info > qtree. After digging through the qdev and qom property maze, it turned > out the property registration in qdev_property_add_legacy and > qdev_property_add_static is

[Qemu-devel] qdev property listing broken

2012-04-02 Thread Jan Kiszka
Hi Anthony, I noticed that only properties with legacy names are printed via info qtree. After digging through the qdev and qom property maze, it turned out the property registration in qdev_property_add_legacy and qdev_property_add_static is not consistent with the access in qdev_print_props. The