Re: [Qemu-devel] pci_change_irq_level is broken...

2011-09-21 Thread Alan Amaral
  Excellent!  Thanks...   Alan From: Jan KiszkaSent: Wed 9/21/2011 12:33 PMTo: Alan AmaralCc: qemu-devel@nongnu.org; r...@twiddle.netSubject: Re: pci_change_irq_level is broken... On 2011-09-21 18:26, Alan Amaral wrote: > > > > > From: Jan Kiszka > Sent: Tue 9/20/2011 3:41 PM > To: Alan

Re: [Qemu-devel] pci_change_irq_level is broken...

2011-09-21 Thread Alan Amaral
my earlier reply to Jan Kiszka for full details. Thanks, Alan From: Richard Henderson Sent: Tue 9/20/2011 3:56 PM To: Alan Amaral Cc: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] pci_change_irq_level is broken... On 09/20/2011 12:19 PM, Alan Amaral wrote: > QEMU emulator version 0.14.

Re: [Qemu-devel] pci_change_irq_level is broken...

2011-09-21 Thread Jan Kiszka
On 2011-09-21 18:26, Alan Amaral wrote: > > > > > From: Jan Kiszka > Sent: Tue 9/20/2011 3:41 PM > To: Alan Amaral > Cc: Richard Henderson; qemu-devel@nongnu.org > Subject: Re: pci_change_irq_level is broken... > >> On 2011-09-20 21:19, Alan Amaral wrote: >>> QEMU emulator version 0.14.50, C

Re: [Qemu-devel] pci_change_irq_level is broken...

2011-09-21 Thread Alan Amaral
From: Jan Kiszka Sent: Tue 9/20/2011 3:41 PM To: Alan Amaral Cc: Richard Henderson; qemu-devel@nongnu.org Subject: Re: pci_change_irq_level is broken... > On 2011-09-20 21:19, Alan Amaral wrote: > > QEMU emulator version 0.14.50, Copyright (c) 2003-2008 Fabrice Bellard > > (That's an ambiti

Re: [Qemu-devel] pci_change_irq_level is broken...

2011-09-20 Thread Richard Henderson
On 09/20/2011 12:19 PM, Alan Amaral wrote: > QEMU emulator version 0.14.50, Copyright (c) 2003-2008 Fabrice Bellard > You are correct, it's not hardcoded to 4. However, when it's allocated the > number of elements IS 4. Also, > there's a comment just above pci_set_irq which says: > > /* 0 <= i

Re: [Qemu-devel] pci_change_irq_level is broken...

2011-09-20 Thread Jan Kiszka
On 2011-09-20 21:19, Alan Amaral wrote: > QEMU emulator version 0.14.50, Copyright (c) 2003-2008 Fabrice Bellard (That's an ambitious development version.) > > You are correct, it's not hardcoded to 4. However, when it's allocated the > number of elements IS 4. Also, > there's a comment just

Re: [Qemu-devel] pci_change_irq_level is broken...

2011-09-20 Thread Alan Amaral
0 or 1 */ static void pci_set_irq(void *opaque, int irq_num, int level) so, that implies to me that it's probably always 4... Sorry for the confusion. From: Richard Henderson Sent: Tue 9/20/2011 2:57 PM To: Alan Amaral Cc: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] pci_change_irq_level is

Re: [Qemu-devel] pci_change_irq_level is broken...

2011-09-20 Thread Richard Henderson
On 09/20/2011 10:24 AM, Alan Amaral wrote: > I'm not on this mailing list, so please CC me on any replies. Thanks. > > I ran qemu with valgrind last night and found an error in the pci emulation > code, which may, > or may not, be biting us. So far the effects seem benign, although there > ex

[Qemu-devel] pci_change_irq_level is broken...

2011-09-20 Thread Alan Amaral
I'm not on this mailing list, so please CC me on any replies.  Thanks.   I ran qemu with valgrind last night and found an error in the pci emulation code, which may, or may not, be biting us.  So far the effects seem benign, although there exists the possibility of trashing random memory.   In