Re: [Qemu-devel] patch for supporting SMB on Solaris host

2006-12-23 Thread Ben Taylor
Lennert Buytenhek <[EMAIL PROTECTED]> wrote: > On Fri, Dec 22, 2006 at 08:40:27PM -0500, Ben Taylor wrote: > > > -snprintf(smb_cmdline, sizeof(smb_cmdline), "/usr/sbin/smbd -s %s", > > - smb_conf); > > +snprintf(smb_cmdline, sizeof(smb_cmdline), "% -s %s", > > +

Re: [Qemu-devel] patch for supporting SMB on Solaris host

2006-12-22 Thread Lennert Buytenhek
On Fri, Dec 22, 2006 at 08:40:27PM -0500, Ben Taylor wrote: > -snprintf(smb_cmdline, sizeof(smb_cmdline), "/usr/sbin/smbd -s %s", > - smb_conf); > +snprintf(smb_cmdline, sizeof(smb_cmdline), "% -s %s", > + SMBD_BINARY, smb_conf); Doesn't look right to me? (s/%/%s/

Re: [Qemu-devel] patch for supporting SMB on Solaris host

2006-12-22 Thread Ben Taylor
Paul Brook <[EMAIL PROTECTED]> wrote: > On Friday 22 December 2006 21:29, Paul Brook wrote: > > On Friday 22 December 2006 20:07, Ben Taylor wrote: > > > Seeing as there is some working going on in the Solaris QEMU port again, > > > here's a real short patch to support Samba working on a Sol

Re: [Qemu-devel] patch for supporting SMB on Solaris host

2006-12-22 Thread Ben Taylor
Paul Brook <[EMAIL PROTECTED]> wrote: > On Friday 22 December 2006 21:29, Paul Brook wrote: > > On Friday 22 December 2006 20:07, Ben Taylor wrote: > > > Seeing as there is some working going on in the Solaris QEMU port again, > > > here's a real short patch to support Samba working on a Sol

Re: [Qemu-devel] patch for supporting SMB on Solaris host

2006-12-22 Thread Ben Taylor
Paul Brook <[EMAIL PROTECTED]> wrote: > On Friday 22 December 2006 21:29, Paul Brook wrote: > > On Friday 22 December 2006 20:07, Ben Taylor wrote: > > > Seeing as there is some working going on in the Solaris QEMU port again, > > > here's a real short patch to support Samba working on a Sol

Re: [Qemu-devel] patch for supporting SMB on Solaris host

2006-12-22 Thread Paul Brook
On Friday 22 December 2006 21:29, Paul Brook wrote: > On Friday 22 December 2006 20:07, Ben Taylor wrote: > > Seeing as there is some working going on in the Solaris QEMU port again, > > here's a real short patch to support Samba working on a Solaris Host. > > +#ifdef __sun__ > > +snprintf(smb_

Re: [Qemu-devel] patch for supporting SMB on Solaris host

2006-12-22 Thread Paul Brook
On Friday 22 December 2006 20:07, Ben Taylor wrote: > Seeing as there is some working going on in the Solaris QEMU port again, > here's a real short patch to support Samba working on a Solaris Host. > +#ifdef __sun__ > +snprintf(smb_cmdline, sizeof(smb_cmdline), "/bin/env LC_ALL=C > /usr/sfw/sb

[Qemu-devel] patch for supporting SMB on Solaris host

2006-12-22 Thread Ben Taylor
Seeing as there is some working going on in the Solaris QEMU port again, here's a real short patch to support Samba working on a Solaris Host. --- qemu-ORIG/vl.c 2006-12-22 12:29:05.0 -0500 +++ qemu/vl.c 2006-12-22 14:22:17.338815000 -0500 @@ -3069,8 +3069,13 @@ fclose(f);