Re: [Qemu-devel] net: Adding netmap network backend

2014-02-14 Thread Vincenzo Maffione
Ok, this patch should preferably go in before the offloadings. 2014-02-14 16:40 GMT+01:00 Stefan Hajnoczi : > On Fri, Feb 14, 2014 at 02:41:24PM +0100, Vincenzo Maffione wrote: > > It is ok for you if I prepare a patch (touching configure and > > net/netmap.c) that makes sure the host kernel h

Re: [Qemu-devel] net: Adding netmap network backend

2014-02-14 Thread Stefan Hajnoczi
On Fri, Feb 14, 2014 at 02:41:24PM +0100, Vincenzo Maffione wrote: > It is ok for you if I prepare a patch (touching configure and > net/netmap.c) that makes sure the host kernel has the minimum netmap > version required for QEMU to work (and if not just --disable-netmap)? Absolutely. Stefan

Re: [Qemu-devel] net: Adding netmap network backend

2014-02-14 Thread Vincenzo Maffione
Stefan, It is ok for you if I prepare a patch (touching configure and net/netmap.c) that makes sure the host kernel has the minimum netmap version required for QEMU to work (and if not just --disable-netmap)? Cheers, Vincenzo 2014-02-14 11:24 GMT+01:00 Luigi Rizzo : > > > > On Fri, Feb 14,

Re: [Qemu-devel] net: Adding netmap network backend

2014-02-14 Thread Luigi Rizzo
On Fri, Feb 14, 2014 at 2:20 AM, Vincenzo Maffione wrote: > Yes, for sure we need to do a check. > > However, this would involve - I think - some non-trivial modifications to > net/netmap.c, because without NS_MOREFRAG you cannot split a packet over > more "netmap slots/descriptors" (both tx and r

Re: [Qemu-devel] net: Adding netmap network backend

2014-02-14 Thread Vincenzo Maffione
Yes, for sure we need to do a check. However, this would involve - I think - some non-trivial modifications to net/netmap.c, because without NS_MOREFRAG you cannot split a packet over more "netmap slots/descriptors" (both tx and rx side) Therefore I would ask (manly Luigi, since netmap is in-tree

Re: [Qemu-devel] net: Adding netmap network backend

2014-02-14 Thread Stefan Hajnoczi
On Wed, Feb 12, 2014 at 10:01:01PM +0400, Michael Tokarev wrote: > After this patch, qemu fails to build on freebsd with the following > error message: > > net/netmap.c: In function 'netmap_receive_iov': > net/netmap.c:307: error: 'NS_MOREFRAG' undeclared (first use in this function) > net/netmap.

Re: [Qemu-devel] net: Adding netmap network backend

2014-02-12 Thread Michael Tokarev
After this patch, qemu fails to build on freebsd with the following error message: net/netmap.c: In function 'netmap_receive_iov': net/netmap.c:307: error: 'NS_MOREFRAG' undeclared (first use in this function) net/netmap.c:307: error: (Each undeclared identifier is reported only once net/netmap.c: