Re: [Qemu-devel] issue with vgabios lfb and virtio vga

2013-12-12 Thread Gerd Hoffmann
On Fr, 2013-12-13 at 11:58 +1000, Dave Airlie wrote: > On Thu, Dec 12, 2013 at 6:17 PM, Gerd Hoffmann wrote: > > On Do, 2013-12-12 at 09:51 +1000, Dave Airlie wrote: > >> Now the vgabios.c does a check of bar 0 and bar 1 to see if they are > >> 0xfff1 masked, this protects against the the i/o bar

Re: [Qemu-devel] issue with vgabios lfb and virtio vga

2013-12-12 Thread Dave Airlie
On Thu, Dec 12, 2013 at 6:17 PM, Gerd Hoffmann wrote: > On Do, 2013-12-12 at 09:51 +1000, Dave Airlie wrote: >> Now the vgabios.c does a check of bar 0 and bar 1 to see if they are >> 0xfff1 masked, this protects against the the i/o bar but fails to >> protect against the LFB one as PCI BARs don't

Re: [Qemu-devel] issue with vgabios lfb and virtio vga

2013-12-12 Thread Gerd Hoffmann
On Do, 2013-12-12 at 09:51 +1000, Dave Airlie wrote: > Now the vgabios.c does a check of bar 0 and bar 1 to see if they are > 0xfff1 masked, this protects against the the i/o bar but fails to > protect against the LFB one as PCI BARs don't encode the size just the > base address, and a 4k BAR can b

[Qemu-devel] issue with vgabios lfb and virtio vga

2013-12-11 Thread Dave Airlie
Hi Gerd, so I have a bit of a conflict I'm not sure how best to handle between how vgabios.c locates its LFB and how virtio requires the BAR get laid out. So virtio-pci requires the BARs are laid out for MSI support with the config i/o ports at BAR 0, and MSI BAR at BAR 1. Now the vgabios.c does