Re: [Qemu-devel] interrupt mitigation for e1000

2012-07-25 Thread Luigi Rizzo
On Wed, Jul 25, 2012 at 12:12:55PM +0200, Paolo Bonzini wrote: > Il 25/07/2012 11:56, Luigi Rizzo ha scritto: > > On Wed, Jul 25, 2012 at 11:53:29AM +0300, Avi Kivity wrote: > >> On 07/24/2012 07:58 PM, Luigi Rizzo wrote: > >>> I noticed that the various NIC modules in qemu/kvm do not implement > >

Re: [Qemu-devel] interrupt mitigation for e1000

2012-07-25 Thread Paolo Bonzini
Il 25/07/2012 11:56, Luigi Rizzo ha scritto: > On Wed, Jul 25, 2012 at 11:53:29AM +0300, Avi Kivity wrote: >> On 07/24/2012 07:58 PM, Luigi Rizzo wrote: >>> I noticed that the various NIC modules in qemu/kvm do not implement >>> interrupt mitigation, which is very beneficial as it dramatically >>>

Re: [Qemu-devel] interrupt mitigation for e1000

2012-07-25 Thread Avi Kivity
On 07/25/2012 12:56 PM, Luigi Rizzo wrote: >> Indeed. But please drop the #ifdef MITIGATIONs. > > Thanks for the comments. The #ifdef block MITIGATION was only temporary to > point out the differences and run the performance comparisons. Ok. In a patch, the '+' in front of a line serves that,

Re: [Qemu-devel] interrupt mitigation for e1000

2012-07-25 Thread Luigi Rizzo
On Wed, Jul 25, 2012 at 11:53:29AM +0300, Avi Kivity wrote: > On 07/24/2012 07:58 PM, Luigi Rizzo wrote: > > I noticed that the various NIC modules in qemu/kvm do not implement > > interrupt mitigation, which is very beneficial as it dramatically > > reduces exits from the hypervisor. > > > > As a

Re: [Qemu-devel] interrupt mitigation for e1000

2012-07-25 Thread Avi Kivity
On 07/24/2012 07:58 PM, Luigi Rizzo wrote: > I noticed that the various NIC modules in qemu/kvm do not implement > interrupt mitigation, which is very beneficial as it dramatically > reduces exits from the hypervisor. > > As a proof of concept i tried to implement it for the e1000 driver > (patch

Re: [Qemu-devel] interrupt mitigation for e1000

2012-07-25 Thread Stefan Hajnoczi
On Tue, Jul 24, 2012 at 5:58 PM, Luigi Rizzo wrote: > I noticed that the various NIC modules in qemu/kvm do not implement > interrupt mitigation, which is very beneficial as it dramatically > reduces exits from the hypervisor. > > As a proof of concept i tried to implement it for the e1000 driver

[Qemu-devel] interrupt mitigation for e1000

2012-07-24 Thread Luigi Rizzo
I noticed that the various NIC modules in qemu/kvm do not implement interrupt mitigation, which is very beneficial as it dramatically reduces exits from the hypervisor. As a proof of concept i tried to implement it for the e1000 driver (patch below), and it brings tx performance from 9 to 56Kpps o