Re: [Qemu-devel] i386: EFER vs 32-bit CPU

2019-05-30 Thread TeLeMan
On Wed, May 29, 2019 at 7:27 PM Pavel Dovgalyuk wrote: > > Hello! > > > > I found this while debugging the inconsistent saved/restored state of the > virtual machine. > > > > i386 (32 bit) emulation uses this register (in wrmsr and in MMU fault > processing). > > But it does not included in VMSt

Re: [Qemu-devel] i386: EFER vs 32-bit CPU

2019-05-30 Thread Peter Xu
On Thu, May 30, 2019 at 05:00:28PM +0800, Peter Xu wrote: > On Thu, May 30, 2019 at 08:54:38AM +0300, Pavel Dovgalyuk wrote: > > > From: Peter Xu [mailto:pet...@redhat.com] > > > On Wed, May 29, 2019 at 02:26:39PM +0300, Pavel Dovgalyuk wrote: > > > > Hello! > > > > > > > > > > > > > > > > I found

Re: [Qemu-devel] i386: EFER vs 32-bit CPU

2019-05-30 Thread Peter Xu
On Thu, May 30, 2019 at 08:54:38AM +0300, Pavel Dovgalyuk wrote: > > From: Peter Xu [mailto:pet...@redhat.com] > > On Wed, May 29, 2019 at 02:26:39PM +0300, Pavel Dovgalyuk wrote: > > > Hello! > > > > > > > > > > > > I found this while debugging the inconsistent saved/restored state of the > > > v

Re: [Qemu-devel] i386: EFER vs 32-bit CPU

2019-05-29 Thread Pavel Dovgalyuk
> From: Peter Xu [mailto:pet...@redhat.com] > On Wed, May 29, 2019 at 02:26:39PM +0300, Pavel Dovgalyuk wrote: > > Hello! > > > > > > > > I found this while debugging the inconsistent saved/restored state of the > > virtual machine. > > > > > > > > i386 (32 bit) emulation uses this register (in wr

Re: [Qemu-devel] i386: EFER vs 32-bit CPU

2019-05-29 Thread Peter Xu
On Wed, May 29, 2019 at 02:26:39PM +0300, Pavel Dovgalyuk wrote: > Hello! > > > > I found this while debugging the inconsistent saved/restored state of the > virtual machine. > > > > i386 (32 bit) emulation uses this register (in wrmsr and in MMU fault > processing). Sorry if this questi

Re: [Qemu-devel] i386: EFER vs 32-bit CPU

2019-05-29 Thread Pavel Dovgalyuk
> From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > * Pavel Dovgalyuk (dovga...@ispras.ru) wrote: > > > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > > > On 29/05/19 13:30, Dr. David Alan Gilbert wrote: > > > >> Should we add a section for i386, which duplicates efer, or just > > >

Re: [Qemu-devel] i386: EFER vs 32-bit CPU

2019-05-29 Thread Dr. David Alan Gilbert
* Pavel Dovgalyuk (dovga...@ispras.ru) wrote: > > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > > On 29/05/19 13:30, Dr. David Alan Gilbert wrote: > > >> Should we add a section for i386, which duplicates efer, or just > > >> version_id of the main > > VMSD should > > >> be updated? > > > > >

Re: [Qemu-devel] i386: EFER vs 32-bit CPU

2019-05-29 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 29/05/19 13:30, Dr. David Alan Gilbert wrote: > >> Should we add a section for i386, which duplicates efer, or just > >> version_id of the main > VMSD should > >> be updated? > > > > You could do: > > > > #ifdef TARGET_X86_64 > > VMST

Re: [Qemu-devel] i386: EFER vs 32-bit CPU

2019-05-29 Thread Paolo Bonzini
On 29/05/19 13:30, Dr. David Alan Gilbert wrote: >> Should we add a section for i386, which duplicates efer, or just version_id >> of the main VMSD should >> be updated? > > You could do: > > #ifdef TARGET_X86_64 > VMSTATE_UINT64(env.efer, X86CPU), > VMSTATE_UINT64(env.star, X86C

Re: [Qemu-devel] i386: EFER vs 32-bit CPU

2019-05-29 Thread Dr. David Alan Gilbert
* Pavel Dovgalyuk (dovga...@ispras.ru) wrote: > Hello! > > > > I found this while debugging the inconsistent saved/restored state of the > virtual machine. > > > > i386 (32 bit) emulation uses this register (in wrmsr and in MMU fault > processing). > > But it does not included in VMState

[Qemu-devel] i386: EFER vs 32-bit CPU

2019-05-29 Thread Pavel Dovgalyuk
Hello! I found this while debugging the inconsistent saved/restored state of the virtual machine. i386 (32 bit) emulation uses this register (in wrmsr and in MMU fault processing). But it does not included in VMState, because "efer" field is disabled with #ifdef TARGET_X86_64 I thin