Re: [Qemu-devel] hw/serial.c: Xmit fifo never used

2010-05-28 Thread Paul Brook
> The problem is that this path is never used as tsr_retry is never > 0 > initially. So if qemu_chr_write() fails, we never try again but drop qemu_chr_write is a blocking interface. It should only fail if an unrecoverable error occurs. In that case there's noting useful we can do, and no reason

[Qemu-devel] hw/serial.c: Xmit fifo never used

2010-05-26 Thread Frank Mehnert
Hi, the xmit fifo of the serial device is never used. If qemu_chr_write() fails (interface currently not able to send characters) then the transmit_timer should be engaged to try to send the current character from the fifo again after some time. The code is } else if (qemu_chr_write(s->chr, &